Benchmark/scalar advection #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greole
reviewed
Dec 30, 2024
Comment on lines
+5
to
+11
| #include "NeoFOAM/dsl/expression.hpp" | ||
| #include "NeoFOAM/dsl/solver.hpp" | ||
| #include "NeoFOAM/dsl/ddt.hpp" | ||
| #include "FoamAdapter/readers/foamDictionary.hpp" | ||
|
|
||
| #include "NeoFOAM/dsl/implicit.hpp" | ||
| #include "NeoFOAM/dsl/explicit.hpp" |
There was a problem hiding this comment.
Suggested change
| #include "NeoFOAM/dsl/expression.hpp" | |
| #include "NeoFOAM/dsl/solver.hpp" | |
| #include "NeoFOAM/dsl/ddt.hpp" | |
| #include "FoamAdapter/readers/foamDictionary.hpp" | |
| #include "NeoFOAM/dsl/implicit.hpp" | |
| #include "NeoFOAM/dsl/explicit.hpp" | |
| #include "FoamAdapter/readers/foamDictionary.hpp" | |
| #include "NeoFOAM/NeoFOAM.hpp" |
If there are no hard objections i would propose to use obr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds to new example scalarFoamAdvection and scalarNeoFoamAdvection
and a very unsophisticated benchmark for discussion and to try it out
The goal of NeoFOAM is to reduce the clockTime of solvers while ensuring the same results. The implementation of a Foam and NeoFOAM version side by side would enables us to understand the performance impact and also guides a way to a clean syntax
Features:
This benchmarking is quite tedious and should be automated with snakemake to do quick parameter scans.
What are your thoughts about a benchmarking with this approach and automating the process as soon as possible?
@gregorweiss @greole @bevanwsjones
Note: The Serial and the OpenFOAM implementation of NeoFOAM show a similar performance