Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Problem: rpc server handler crash when the rpc call send_transaction missing the gas related arguments #625

Closed
JayT106 opened this issue Oct 5, 2021 · 0 comments · Fixed by #697

Comments

@JayT106
Copy link
Contributor

JayT106 commented Oct 5, 2021

System info: [Include Ethermint commit, operating system name, and other relevant details]

__Steps to reproduce:

When I was fixing the rpc-test with main branch, 202bc5f
some tests are missing the gas info in the sending param.
i.e.
TestEth_SendTransaction_ContractDeploy
When running these tests against ethermintd, we can see the ERR msg on the server-side.

4:11PM ERR Failed to read request err="websocket: close 1006 (abnormal closure): unexpected EOF" module=rpc-server protocol=websocket remote={"IP":"127.0.0.1","Port":64346,"Zone":""} server=node

And the test case failed with the message

Expected nil, but got: &rpc.Error{Code:-32000, Message:"method handler crashed", Data:interface {}(nil)}

__Expected behavior:
The rpc server should handle the eth_sendTransaction with missing tx arguments

__Additional info:
issue happens when working on
#608

@JayT106 JayT106 changed the title Problem: rpc server handler crashed when the rpc call send_transaction missing the gas related arguments Problem: rpc server handler crash when the rpc call send_transaction missing the gas related arguments Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant