"unknown revision or path not in the working tree" from 1.6.15 onwards

[alecthomas]

🔧 Summary

After upgrading from lefthook 1.6.14 to 1.6.15 (or higher), every push results in the following output:

🐚 ~/dev/ftl $ git push                                                                                                       aat/bump-lefthook-2
⠋ waitingfatal: ambiguous argument '@{push}': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
fatal: ambiguous argument '@{push}': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
fatal: ambiguous argument '@{push}': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
fatal: ambiguous argument '@{push}': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
fatal: ambiguous argument '@{push}': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

This only occurs if the remote branch doesn't already exist. Once it exists everything works fine.

On 1.6.14 this works in either case.

Lefthook version

1.6.15 a58c11d

Steps to reproduce

I'm not sure, it happens 100% of the time for me. Let me know if there's any further information you'd need to reproduce it.

Possible Solution

Logs / Screenshots

🐚 ~/dev/ftl $ LEFTHOOK_VERBOSE=true git push                                                                                 aat/bump-lefthook-2
+ '[' '' = 0 ']'
+ call_lefthook run pre-push origin git@github.com:TBD54566975/ftl.git
+ test -n ''
+ lefthook -h
+ lefthook run pre-push origin git@github.com:TBD54566975/ftl.git
│ [lefthook] cmd: [git rev-parse --show-toplevel]
│ [lefthook] err: <nil>
│ [lefthook] out: /Users/alec/dev/ftl
                                   
│ [lefthook] cmd: [git rev-parse --git-path hooks]
│ [lefthook] err: <nil>
│ [lefthook] out: .git/hooks
                          
│ [lefthook] cmd: [git rev-parse --git-path info]
│ [lefthook] err: <nil>
│ [lefthook] out: .git/info
                         
│ [lefthook] cmd: [git rev-parse --git-dir]
│ [lefthook] err: <nil>
│ [lefthook] out: .git
                    
│ [lefthook] cmd: [git hash-object -t tree /dev/null]
│ [lefthook] err: <nil>
│ [lefthook] out: 4b825dc642cb6eb9a060e54bf8d69288fbee4904
                                                        
│ [lefthook] cmd: [git diff --name-only HEAD @{push}]
│ [lefthook] cmd: [git diff --name-only HEAD @{push}]
│ [lefthook] dir: /Users/alec/dev/ftl
│ [lefthook] cmd: [git diff --name-only HEAD @{push}]
│ [lefthook] dir: /Users/alec/dev/ftl
│ [lefthook] cmd: [git diff --name-only HEAD @{push}]
│ [lefthook] dir: /Users/alec/dev/ftl
│ [lefthook] dir: /Users/alec/dev/ftl
│ [lefthook] cmd: [git diff --name-only HEAD @{push}]
│ [lefthook] dir: /Users/alec/dev/ftl
fatal: ambiguous argument '@{push}': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
fatal: ambiguous argument '@{push}': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
│ [lefthook] err: exit status 128
│ [lefthook] out: 
│ [lefthook] cmd: [git branch --remotes]
│ [lefthook] dir: /Users/alec/dev/ftl
│ [lefthook] err: exit status 128
│ [lefthook] out: 
│ [lefthook] cmd: [git branch --remotes]
│ [lefthook] dir: /Users/alec/dev/ftl

[mrexox]

Hey @alecthomas! Is the issue only related to odd error messages in STDOUT or lefthook fails to run the pre-push hook too?

[alecthomas]

It seems to run to completion fine I think, though it's very disconcerting :)

[mrexox]

Ok, I could reproduce this and I made a fix for this. Will release it ASAP 👍

[alecthomas]

🙏

We love Lefthook BTW, thanks for all the hard work.