Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git execution inconsistency #105

Closed
lionskape opened this issue Jan 24, 2020 · 0 comments
Closed

Git execution inconsistency #105

lionskape opened this issue Jan 24, 2020 · 0 comments

Comments

@lionskape
Copy link

lionskape commented Jan 24, 2020

Here is an issue - "sh" is not found in PATH, while executing in PowerShell or CMD environment.
https://github.com/Arkweid/lefthook/blob/master/cmd/root.go#L110

But the project already have a solution to run git command in Windows environment
https://github.com/Arkweid/lefthook/blob/master/context/context_windows.go#L22

Why it is not used?

Also it will resolve #91 and #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant