Skip to content
This repository has been archived by the owner on Aug 3, 2021. It is now read-only.

Ch.7 p80 - expected is not used in require_login.rb #90

Open
JunichiIto opened this issue Feb 21, 2014 · 1 comment
Open

Ch.7 p80 - expected is not used in require_login.rb #90

JunichiIto opened this issue Feb 21, 2014 · 1 comment

Comments

@JunichiIto
Copy link

In Ch.7 p80, there are actual and expected in require_login.rb, but expected is not used in it. This might lead to confusing. So adding some description would be helpful for understanding.

E.g.
We check to see if the actual, expected value we're passing to the matcher (in this case, response as actual only) does what we expect it to (redirect to our login form).

This issue was reported from one of our readers.

@ruralocity
Copy link
Member

I've never been happy with this contrived example. I got rid of actual, expected for now and changed the link for more information to the Relish documentation. I want to revisit this and come up with a better example for the next major release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants