Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncated loadpoint name on mobile with small display #3427

Closed
scharph opened this issue May 20, 2022 · 3 comments · Fixed by #3720
Closed

Truncated loadpoint name on mobile with small display #3427

scharph opened this issue May 20, 2022 · 3 comments · Fixed by #3720
Assignees
Labels
ux User experience/ interface

Comments

@scharph
Copy link

scharph commented May 20, 2022

The loadpoint name is truncated, when a small display is used like iPhone SE
evcc_bug

Describe the solution you'd like
The Mode panel could be moved and presented centered under the actual values, so the loadpointname has enough space
image

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context

changed some mb-3 to mb2
and justify-content-center for centering of the panel

diff --git a/assets/js/components/Loadpoint.vue b/assets/js/components/Loadpoint.vue
index f9df86fe..7fbf7320 100644
--- a/assets/js/components/Loadpoint.vue
+++ b/assets/js/components/Loadpoint.vue
@@ -1,15 +1,9 @@
 <template>
        <div class="loadpoint bg-white p-4">
-               <div class="d-flex justify-content-between align-items-center mb-3">
-                       <h3 class="mb-3 me-2 text-truncate">
+               <div class="d-flex justify-content-between align-items-center">
+                       <h3 class="mb-2 me-2 text-truncate">
                                {{ title || $t("main.loadpoint.fallbackName") }}
                        </h3>
-                       <div class="mb-3 d-flex align-items-center">
-                               <Mode :mode="mode" @updated="setTargetMode" />
-                               <button v-if="$hiddenFeatures" class="btn btn-link text-gray p-0 flex-shrink-0">
-                                       <shopicon-filled-options size="s"></shopicon-filled-options>
-                               </button>
-                       </div>
                </div>
 
                <div
@@ -28,7 +22,7 @@
                        }}
                </div>
 
-               <div class="details d-flex align-items-start mb-3">
+               <div class="details d-flex align-items-start mb-2">
                        <div>
                                <div class="d-flex align-items-center">
                                        <LabelAndValue
@@ -64,6 +58,12 @@
                                        ${fmtShortDurationUnit(chargeDurationInterpolated)}`"
                        />
                </div>
+               <div class="mb-2 d-flex justify-content-center">
+                       <Mode :mode="mode" @updated="setTargetMode" />
+                       <button v-if="$hiddenFeatures" class="btn btn-link text-gray p-0 flex-shrink-0">
+                               <shopicon-filled-options size="s"></shopicon-filled-options>
+                       </button>
+               </div>
                <Vehicle
@andig
Copy link
Member

andig commented May 20, 2022

Danke für das Issue. Momentan by design.

@andig andig added the enhancement New feature or request label May 20, 2022
@naltatis
Copy link
Member

Wir haben das Thema auf dem Zettel. Die Elemente in mehrere Zeilen ziehen geht natürlich, führt aber zu anderen Probleme, da bspw der footer oder andere Werte auf kleine phones aus dem viewport rutscht.

Wir werden als nächsten Schritt die Moduswahl vereinfachen und damit kompakter machen. Damit gibts auch wieder mehr Platz für den Namen des Loadpoints.

@andig andig added ux User experience/ interface and removed enhancement New feature or request labels May 22, 2022
@ThomDietrich
Copy link

@naltatis gibt es ein Ticket mit Diskussion zu besagter Vereinfachung der Modusauswahl? Die aktuellen Modi könnten optimiert werden, ich wurde aber schon von einer Ansicht verwirrt die lediglich "Cheap" und "Fast" zeigte...

@github-actions github-actions bot added the stale Outdated and ready to close label Jun 13, 2022
@naltatis naltatis reopened this Jun 19, 2022
@naltatis naltatis removed the stale Outdated and ready to close label Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux User experience/ interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants