-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] banner and footer #482
Comments
Yes, I think a feature like this makes sense. Another issue with However, if I support that then these prefix and suffix strings aren't actually valid JavaScript code, and for example won't be able to be minified. I think that should be fine though since this is a very custom use case and you can always minify them yourself if needed. |
Yes, agreed. And to your latter point, I would argue that this is fine since it would make sense that the banner and footer (or prefix and suffix if you prefer these names) are added to the bundle(s) as late in the compilation process as possible, even after minification. |
I wanted to make a contribution to this project and pick up a bit of go along the way. Here is my attempt at adding support for those options: #531 |
Feature Request
I would like to propose a
banner
andfooter
option, as seen in Rollup and documented here.From what I've been able to gather, and based on my own testing, the new
inject
option doesn't quite allow for this behavior, so I feel like this one is needed.Use case
One common use case is for adding a license or another relevant comment in the top of a bundle in a way that doesn't break source maps.
The text was updated successfully, but these errors were encountered: