-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Q] Very short line segments in combined.json? #63
Comments
There are 3 methods in which the boundary lines are generated or manipulated in the boundary building process.
As I mentioned in #17, I still think it is best for downstream users of the data produced in this project to pursue data simplification at their own risk and let this project have some of the artifacts of absurdly precise data so long as the data is not wrong. |
I just thought of one other boundary manipulation process that occurs in this code. In order to resolve #11, this script will look at the resulting boundaries and find and remove any holes in polygons that have a very small area. This should result in less of those very short line segments since they might be removed altogether. |
Thank you @evansiroky. One of the results I found was that 209 line segments are having the same minimum length = 9.999999974752427e-7. So I concluded they are generated by a software operation, rather than human input. By the way, Natural Earth site also offers the country boundary line data. Though the update of the data seems to be a bit slow, it seems that the site is offering high resolution and reliable data. |
I'm also not sure what the glitch you are describing is the result of, especially since it is unclear where exactly any of these glitches are happening. With regards to the natural earth data, that data is not used for 3 reasons.
As you can see, the data in OpenStreetMap is much more precise and accurate.
|
Oh my... The natural earth data is not more reliable than I thought. Thank you @evansiroky for your great job. |
Below 4 images(screen captured) are the examples of the glitch lines. The marker positions are the start points of the glitch lines. The coordinates of the markers are shown in right side of bottom message.
|
Thanks for posting these examples and coordinates. I'm rather busy with my day job right now, but I'm reopening this as a reminder to take a look before the next release. |
For the first {
"type": "node",
"id": 2156620436,
"lat": 51.4536259,
"lon": 4.6945512
},
{
"type": "node",
"id": 2156620437,
"lat": 51.4536266,
"lon": 4.6945517
} And the third example has the following extremely close together nodes: {
"type": "node",
"id": 2156629391,
"lat": 51.4427372,
"lon": 4.6668953
},
{
"type": "node",
"id": 2156629393,
"lat": 51.4427380,
"lon": 4.6668952
} The level of precision here is probably unneeded, but it is coming from OpenStreetMap, so I don't think this is a problem originating from this library. I'm going to go ahead and close this because this project aims to use data that is as close as possible to what is found in OpenStreetMap. |
I found lots of very short line segments in
combined.js
. The minimum length of the short line segments is about 1/300 arc seconds, which is not practical. Though I did not check all of them, some of them look like just line glitches, which could be generated by erroneous software operations, such as careless converting rasterized lines to vector lines.I tried to simplify those lines, because they are disturbing look-up program. But I found that the problems are not simple. If I simplify a timezone boundary, it can overlap or make gaps with adjacent timezone boundary.
How these short lines were generated, and how I can safely remove/simplify them?
The text was updated successfully, but these errors were encountered: