Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate identifier causing broken build with typescript. #150

Closed
jcloutz-radix opened this issue Oct 28, 2021 · 3 comments
Closed

Duplicate identifier causing broken build with typescript. #150

jcloutz-radix opened this issue Oct 28, 2021 · 3 comments

Comments

@jcloutz-radix
Copy link

Describe the bug 🐛
EnvVarError is exported twice from the env-var.d.ts file.

$ nest build
node_modules/env-var/env-var.d.ts:263:14 - error TS2300: Duplicate identifier 'EnvVarError'.

263 export class EnvVarError extends Error ***
                 ~~~~~~~~~~~
node_modules/env-var/env-var.d.ts:308:14 - error TS2300: Duplicate identifier 'EnvVarError'.

308 export const EnvVarError: EnvVarError
                 ~~~~~~~~~~~

Found 2 error(s).

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
The command '/bin/sh -c yarn build' returned a non-zero code: 1

To Reproduce 📝
build a typescript project with the latest version.

Expected behaviour 🤷‍♂️🤷
no broken builds would be nice 😃

Environment (please complete the following information) 💻:

  • OS: Ubuntu
  • Runtime Node.js
  • Version 7.1.0
@evanshortiss
Copy link
Owner

Fixed in 7.1.1 thanks to @avocadomaster for the fix, and thanks for the report @jcloutz-radix.

I'll investigate how to catch this in builds/CI.

@evanshortiss
Copy link
Owner

@avocadomaster @Lioness100 @jcloutz-radix lib files are now checked in builds (commit), so these errors will be caught in the future.

@jcloutz-radix
Copy link
Author

Awesome, thank you @evanshortiss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants