Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure encoder options - compression level #21

Open
dbernheisel opened this issue Jan 16, 2025 · 1 comment · May be fixed by #23
Open

Configure encoder options - compression level #21

dbernheisel opened this issue Jan 16, 2025 · 1 comment · May be fixed by #23

Comments

@dbernheisel
Copy link

dbernheisel commented Jan 16, 2025

Scenario: I have a bunch of video that I want to pack into a zip file. Typically with video, the files are already compressed, so compressing again via Packmatic would be largely wasteful.

It looks like the Encoder is hardcoded to use deflate with compression :default and I'd like to set this to 0 so it's just storage and speed up.

I'll be happy to submit a patch that can include the compression level as an Encoder.option that passes it to deflateInit, or whatever you prefer. Let me know. I'm using Packmatic.build_stream with a list of streams provided to it, so I'm hoping to give it Packmatic.build_stream(streams, compression_level: 0).

@dbernheisel dbernheisel changed the title Configure encoder options Configure encoder options - compression level Jan 16, 2025
@dbernheisel
Copy link
Author

Just checking in! I'm planning on submitting a PR within the next week or two so I can relieve some CPU on my servers.

@dbernheisel dbernheisel linked a pull request Feb 7, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant