Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ordering in ensemble csv is locale-dependent #784

Closed
Bisaloo opened this issue Aug 11, 2021 · 2 comments
Closed

Ordering in ensemble csv is locale-dependent #784

Bisaloo opened this issue Aug 11, 2021 · 2 comments
Assignees
@Bisaloo
Labels
bug Something isn't working

Comments

@Bisaloo
Copy link
Member

Bisaloo commented Aug 11, 2021

which creates unnecessary diffs: be9803c
@Bisaloo Bisaloo added the bug Something isn't working label Aug 11, 2021
@Bisaloo Bisaloo self-assigned this Aug 11, 2021
@Bisaloo Bisaloo changed the title Ordering of ensemble csv is locale-dependent Ordering in ensemble csv is locale-dependent Aug 11, 2021
@Bisaloo
Copy link
Member Author

Bisaloo commented Aug 11, 2021

This comes from load_forecasts() so I opened an issue in covidHubUtils to see if they're interested in tackling it on their side: reichlab/covidHubUtils#291. If they don't think it's worth it, we can wrap load_forecasts() calls with withr::with_locale() as a workaround.

@Bisaloo
Copy link
Member Author

Bisaloo commented Aug 16, 2021

Should be fixed by reichlab/covidHubUtils#293. I'll run some tests and then close this issue.

@Bisaloo Bisaloo closed this as completed Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bisaloo Bisaloo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bisaloo