From f45a23aaa61147a00d4aee9ef83c205e19b3dbd2 Mon Sep 17 00:00:00 2001
From: Lucano Vera <lucanovera@live.com.ar>
Date: Wed, 5 Feb 2025 17:18:47 -0300
Subject: [PATCH 1/3] LJ-343 Allow search by default in all Selects

---
 clients/fidesui/src/hoc/CustomSelect.tsx | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/clients/fidesui/src/hoc/CustomSelect.tsx b/clients/fidesui/src/hoc/CustomSelect.tsx
index 47725b4731..7ff13bbefa 100644
--- a/clients/fidesui/src/hoc/CustomSelect.tsx
+++ b/clients/fidesui/src/hoc/CustomSelect.tsx
@@ -36,6 +36,7 @@ const withCustomProps = (WrappedComponent: typeof Select) => {
     placeholder = "Select...",
     optionRender = optionDescriptionRender,
     className = "w-full",
+    showSearch = true,
     suffixIcon,
     menuItemSelectedIcon = <Checkmark />,
     ...props
@@ -44,6 +45,7 @@ const withCustomProps = (WrappedComponent: typeof Select) => {
       placeholder,
       optionRender,
       className,
+      showSearch,
       suffixIcon: props.loading ? undefined : suffixIcon || <ChevronDown />,
       menuItemSelectedIcon,
       "data-testid": `select${props.id ? `-${props.id}` : ""}`,

From c893f1e535774d62777c6b8cef900b230ee87a51 Mon Sep 17 00:00:00 2001
From: Lucano Vera <lucanovera@live.com.ar>
Date: Wed, 5 Feb 2025 17:25:23 -0300
Subject: [PATCH 2/3] Update changelog

---
 CHANGELOG.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index eb49f266f2..a98a5b29b6 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -25,6 +25,8 @@ Changes can also be flagged with a GitHub label for tracking purposes. The URL o
 - Added frequency field to DataHubSchema integration config [#5716](https://github.com/ethyca/fides/pull/5716)
 - Added glossary_node field to DataHubSchema integration config [#5734](https://github.com/ethyca/fides/pull/5734)
 - Added initial support for upcoming "headless" CMP experience type [#5731](https://github.com/ethyca/fides/pull/5731)
+- All Select dropdowns will now allow searching to narrow down the options by default [#5738](https://github.com/ethyca/fides/pull/5738)
+
 
 ### Fixed
 - Fixed `fides annotate dataset` command enters incorrect value on the `direction` field. [#5727](https://github.com/ethyca/fides/pull/5727)

From 36d65ea7daddda4dbb1edf3a30544c2abd4c9a77 Mon Sep 17 00:00:00 2001
From: Lucano Vera <lucanovera@live.com.ar>
Date: Wed, 5 Feb 2025 17:59:52 -0300
Subject: [PATCH 3/3] remove props no longer needed

---
 clients/admin-ui/src/features/common/ScrollableList.tsx     | 1 -
 .../admin-ui/src/features/common/dropdown/SystemSelect.tsx  | 6 +-----
 .../src/features/common/dropdown/TaxonomySelect.tsx         | 1 -
 .../system_portal_config/forms/SelectDataset.tsx            | 1 -
 clients/admin-ui/src/features/system/VendorSelector.tsx     | 1 -
 5 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/clients/admin-ui/src/features/common/ScrollableList.tsx b/clients/admin-ui/src/features/common/ScrollableList.tsx
index 26c2232123..23e49f67fb 100644
--- a/clients/admin-ui/src/features/common/ScrollableList.tsx
+++ b/clients/admin-ui/src/features/common/ScrollableList.tsx
@@ -121,7 +121,6 @@ const ScrollableListAdd = ({
   return isAdding ? (
     <Box w="full">
       <Select
-        showSearch
         labelInValue
         placeholder="Select..."
         filterOption={(input, option) =>
diff --git a/clients/admin-ui/src/features/common/dropdown/SystemSelect.tsx b/clients/admin-ui/src/features/common/dropdown/SystemSelect.tsx
index f24d2e1227..66dacf18d4 100644
--- a/clients/admin-ui/src/features/common/dropdown/SystemSelect.tsx
+++ b/clients/admin-ui/src/features/common/dropdown/SystemSelect.tsx
@@ -33,10 +33,7 @@ const dropdownRender = (
 };
 
 interface SystemSelectProps
-  extends Omit<
-    SelectProps,
-    "options" | "showSearch" | "filterOption" | "onSearch"
-  > {
+  extends Omit<SelectProps, "options" | "filterOption" | "onSearch"> {
   onAddSystem?: MouseEventHandler<HTMLButtonElement>;
 }
 
@@ -77,7 +74,6 @@ export const SystemSelect = ({ onAddSystem, ...props }: SystemSelectProps) => {
       }
       data-testid="system-select"
       {...props}
-      showSearch
       filterOption={false}
       options={options}
       onSearch={onSearch}
diff --git a/clients/admin-ui/src/features/common/dropdown/TaxonomySelect.tsx b/clients/admin-ui/src/features/common/dropdown/TaxonomySelect.tsx
index 83a643a01f..a7a01fa3e2 100644
--- a/clients/admin-ui/src/features/common/dropdown/TaxonomySelect.tsx
+++ b/clients/admin-ui/src/features/common/dropdown/TaxonomySelect.tsx
@@ -48,7 +48,6 @@ export const TaxonomySelect = ({
     <Select<string, TaxonomySelectOption>
       options={selectOptions}
       autoFocus
-      showSearch
       variant="borderless"
       optionRender={TaxonomyOption}
       dropdownStyle={{ minWidth: "500px" }}
diff --git a/clients/admin-ui/src/features/datastore-connections/system_portal_config/forms/SelectDataset.tsx b/clients/admin-ui/src/features/datastore-connections/system_portal_config/forms/SelectDataset.tsx
index 63cbe81d02..ee90cc7e26 100644
--- a/clients/admin-ui/src/features/datastore-connections/system_portal_config/forms/SelectDataset.tsx
+++ b/clients/admin-ui/src/features/datastore-connections/system_portal_config/forms/SelectDataset.tsx
@@ -36,7 +36,6 @@ const SelectDataset = ({ options }: { options?: Option[] }) => {
             options={options}
             onChange={(v) => setValue(v)}
             mode="multiple"
-            showSearch
             className="w-full"
           />
         </Box>
diff --git a/clients/admin-ui/src/features/system/VendorSelector.tsx b/clients/admin-ui/src/features/system/VendorSelector.tsx
index 91291d9f09..4693fe129c 100644
--- a/clients/admin-ui/src/features/system/VendorSelector.tsx
+++ b/clients/admin-ui/src/features/system/VendorSelector.tsx
@@ -201,7 +201,6 @@ const VendorSelector = ({
         <Box width="100%" className="relative">
           <Select<VendorOption, VendorOption>
             id="vendorName"
-            showSearch
             labelInValue
             autoFocus
             allowClear