Wallet Signer calculates wrong account when provided 64-byte private key buffer

[ritave]

Ethers Version

5.6.4

Search Terms

wallet, sign

Describe the Problem

Please see the code snippet, it's all explained there.

My expected behaviour would be to throw an error when the provided private key is not the correct size.

Thank you to @Mrtenz for debugging the error.

Code Snippet

// Version used: @metamask/key-tree@3.0.1
import { BIP44CoinTypeNode } from '@metamask/key-tree';
import { Wallet } from 'ethers';

const node = new BIP44CoinTypeNode([
      `bip39:toilet year elite cabin army same grocery ridge ticket identify gift adapt`,
      `bip32:44'`,
      `bip32:60'`,
    ]);
// The current publicly released key-tree returns a 64-byte buffer with first 32-bytes being the private key
// And second 32-bytes being the chain code
const key = node.deriveBIP44AddressKey({ account: 0, change: 0, address_index: 0});

let wallet = new Wallet(key);
// Wrong address returned: 0xe08356b9A7ADDCc13Dc4F4768b55a870217F716A
console.log(wallet.address);

wallet = new Wallet(key.slice(0, 32));
// Expected address returned: 0x67AA6d3C483c8461f00483d09d506A83D696d17a
console.log(wallet.address);

Contract ABI

No response

Errors

No response

Environment

Browser (Chrome, Safari, etc)

Environment (Other)

No response

[ricmoo]

Fixed in 5.6.5 (See 7b299dd).

Thanks! :)