Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stateManager: add modifyAccountFields method #731

Closed
s1na opened this issue Apr 27, 2020 · 2 comments · Fixed by #1369
Closed

stateManager: add modifyAccountFields method #731

s1na opened this issue Apr 27, 2020 · 2 comments · Fixed by #1369

Comments

@s1na
Copy link
Contributor

s1na commented Apr 27, 2020

Discussing the API with @jochem-brouwer we thought it might be easier from a developer PoV to have a modifyAccountFields that internally fetches an account from the trie, modify the given fields and then do a putAccount. This is to avoid users having to to the getAccount everytime they want to change an account. The method should probably throw if account doesn't exist.

@holgerd77
Copy link
Member

This is still open (I would also say still useful?) and a potentially good first issue for some trie-releated StateManager/VM work.

Please assign yourself if you want to take and also add a test case testing the new method.

@emersonmacro
Copy link
Contributor

I can try to tackle this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants