-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev version installation fails on node v12 #661
Comments
The
I think it would make sense to keep this (relatively) in sync rather than update on one side and do an update both on the |
Level-family packages has the same interface and AFAIK backward compatible interfaces, so it seems safe and reliable to update only a single package. This update is required to fix node native package installation issue and as you can see in PR #662 all tests passed well even with the current |
Ok, that makes sense. Not that much of a level expert and always unsure on how conservative to be here in updates. |
Seems sensible to me to pack changes together in the monorepo. |
@evertonfraga There should be a label |
Fixed by #662 |
Development version of VM installation fails on node v12. The problem is caused by levedown native module compilation failure. Leveldown is a dependency of level package and according to it readme it isn't support current node version.
Reproduce
npm i .
inside of repository directory.Solution
Upgrade level package to the latest version.
Checklist
level
tov6.0.0
.level-mem
tov6.0.0
here and intoethereumjs-blockchain
package, after monorepo migration.The text was updated successfully, but these errors were encountered: