Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Call50000bytesContract tests #657

Closed
chfast opened this issue Nov 12, 2019 · 6 comments · Fixed by #658
Closed

Change Call50000bytesContract tests #657

chfast opened this issue Nov 12, 2019 · 6 comments · Fixed by #658

Comments

@chfast
Copy link
Member

chfast commented Nov 12, 2019

From some HF, the contract size limit is 0x6000 (24576). It is impractical to have tests for a contracts of size 50000 being over 2x larger than the limit.
Please modify the tests to use the limit 0x6000 instead of 50000.

@winsvega
Copy link
Collaborator

ah so the contract still could be 50k bytes theoretically if it was deployed before, but not anymore?
the quadratic complexity tests were done by Vitalik to test the execution speed. if it is still possible that a network has such a code could be worth keeping it the way it is.

are this tests cause a problem in evm ?

@chfast
Copy link
Member Author

chfast commented Nov 13, 2019

are this tests cause a problem in evm ?

Yes, because evmone expects the max code size to be smaller.

@winsvega
Copy link
Collaborator

winsvega commented Nov 13, 2019

what if a contract been deployed with a bigger code size before the HF and evm needs to parse it?

anyway since we have the legacy tests this could be updated to a smaller codesize

@chfast
Copy link
Member Author

chfast commented Nov 13, 2019

what if a contract been deployed with a bigger code size before the HF and evm needs to parse it?

At least it did not happen on mainnet.

@winsvega
Copy link
Collaborator

winsvega commented Nov 13, 2019

check this fix: #658
if its good I shrink the other tests the same way

@winsvega
Copy link
Collaborator

@chfast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants