Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test format check failure in just-cloned repo. #611

Closed
acoglio opened this issue Jul 12, 2019 · 2 comments
Closed

Test format check failure in just-cloned repo. #611

acoglio opened this issue Jul 12, 2019 · 2 comments

Comments

@acoglio
Copy link
Member

acoglio commented Jul 12, 2019

I just cloned the repo and make RLPTests.format results in a git diff error. The .json files under the RLPTests directory show up as modified.

Have I missed some steps? I followed the instructions under 'Test Set Sanitation' at https://github.com/ethereum/tests.

Background: I'd like to make a PR with some new RLP tests and I understand that I should ensure that the sanitation tests pass first, but the problem is that I'm getting this failure without my new tests.

@winsvega
Copy link
Collaborator

winsvega commented Sep 1, 2019

Oh. I don't support this scripts. And it is probably way outdated. Also would not recommend using this scripts for the test filling. Consensus test execution is a separate tooling. Currently there is testeth from aleth to run most of this tests.

To check RLP tests:

./testeth -t RlpTests

Another project to run consensus tests against different client implementations:
https://github.com/ethereum/retesteth

@winsvega
Copy link
Collaborator

#631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants