-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alias a new name to the SHA3 opcode #363
Comments
suggestions for the new name, |
@ethers I would vote for |
^agree with @axic |
@chriseth what would it take for consensus? ;) I'm fine with |
I'm not sure if |
keccak256 would be completely unambiguous, if ambiguity is the issue. |
Btw, in regard to @axic and @VoR0220 comments from Feb, I sincerely hope that "waiting for the EIP" is not the reason this has been held up here. SHA3 is flat out inaccurate, and it confuses the hell out of every programmer I introduce to solidity. There is no disadvantage to simply adding an alias as soon as possible so that at least new code can be changed to appear way less confusing outside of the very narrow circle of Etherum people who understand how this happened historically. It will be way less work for everyone coming in if the first thing I can tell them is "Ethereum uses a hash function very similar to SHA3 called Keccak256" and just have them use that in their code from scratch. I highly support the EIP, but a Solidity alias is definitely the lowest hanging fruit to get the ball rolling. /rant |
@emansipater I was actually reconsidering this in the past week and came to a similar conclusion. I don't see a change in EVM or the protocol likely, but at least the RPC documentation could be updated next to Solidity. |
Adding the aliasing makes a lot of sense to me. |
Let's go for |
As a first step to ethereum/EIPs#59
sha3
is usedsha3
is used in new Solidity code.Below the surface, the same existing EVM SHA3 opcode is used by Solidity.
This issue is also a prerequisite if #362 (a Solidity function that does output SHA-3) was ever going to be implemented.
The text was updated successfully, but these errors were encountered: