Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect base fee usage in tracing tests #28773

Closed
palango opened this issue Jan 8, 2024 · 0 comments · Fixed by #28775
Closed

Incorrect base fee usage in tracing tests #28773

palango opened this issue Jan 8, 2024 · 0 comments · Fixed by #28775
Assignees
Labels

Comments

@palango
Copy link
Contributor

palango commented Jan 8, 2024

While working on another issue, I found that in the tracing tests the base fee is generally set to nil (see https://github.com/ethereum/go-ethereum/blob/master/eth/tracers/internal/tracetest/prestate_test.go#L120). Changing this to pass the proper base fee works for most tests, but TestPrestateWithDiffModeTracer runs into problems in the create_failed.json test case.

Here the base fee is 51088069741, and the transactions fee limit is set to 112855938170. The transactions tip cap is 1500000000. This leads to a gas price of 112855938170 when the base fee is not set, but 52588069741 when the base fee is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants