You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 6, 2025. It is now read-only.
Vyper performs implicit conversion for ==, causing a few previously uncaught sources of error.
For example in deposit and logout function, assert self.current_epoch == block.number / self.epoch_length which converts self.current_epoch to decimal rather than converting block.number / self.epoch_length to an int. This line should instead be assert self.current_epoch == floor(block.number / self.epoch_length).
Proposed implementation
Fix assertions mentioned above
Comb the contract for other incorrect implicit type casting and fix
add any relevant tests.
The text was updated successfully, but these errors were encountered:
Issue
Vyper performs implicit conversion for
==
, causing a few previously uncaught sources of error.For example in
deposit
andlogout
function,assert self.current_epoch == block.number / self.epoch_length
which convertsself.current_epoch
todecimal
rather than convertingblock.number / self.epoch_length
to an int. This line should instead beassert self.current_epoch == floor(block.number / self.epoch_length)
.Proposed implementation
The text was updated successfully, but these errors were encountered: