Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarification on what is expected with /eth/v1/beacon/headers #103

Closed
rolfyone opened this issue Oct 22, 2020 · 2 comments
Closed

clarification on what is expected with /eth/v1/beacon/headers #103

rolfyone opened this issue Oct 22, 2020 · 2 comments

Comments

@rolfyone
Copy link
Contributor

  • 2 Query parameters, slot and parent_root, and it's stipulated if no parameters are specified that slot defaults to head...

  • what if both parameters are specified? is it invalid, an OR, or an AND condition?

  • Assuming it's an AND (or OR really), does slot default to head only if there's no parent_root specified?

  • Assuming it's not defaulting slot, and a user specifies parent_root only, then is the expectation that the result would be all canonical and non canonical blocks with this parent?

  • If the block is finalized and only the canonical chain is stored, then we might only get the block with the parent_root on the canonical chain, because some clients may not store blocks that didn't make the chain long term. is that adequate for this endpoint?

@mpetrunic
Copy link
Contributor

what if both parameters are specified? is it invalid, an OR, or an AND condition?

I don't think there is much benefit in OR condition while AND can be useful to get blocks with parentRoot where slot is immeditately after parent slot.

Assuming it's not defaulting slot, and a user specifies parent_root only, then is the expectation that the result would be all canonical and non canonical blocks with this parent?

yes

If the block is finalized and only the canonical chain is stored, then we might only get the block with the parent_root on the canonical chain, because some clients may not store blocks that didn't make the chain long term. is that adequate for this endpoint?

You are returning what you have, if that's only canonical block thats fine, if client has some flag to keep all non-canonical blocks they can return those as well I guess.

@rolfyone
Copy link
Contributor Author

closing ticket, I think this has pretty much gone stale at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants