Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking] EIP-2935: Historical Block Hashes from State #24

Closed
emhane opened this issue Jan 23, 2025 · 8 comments
Closed

[Tracking] EIP-2935: Historical Block Hashes from State #24

emhane opened this issue Jan 23, 2025 · 8 comments
Labels
A-kona Area: kona (rust fault prover) A-op-geth Area: op-geth (go execution client incl. go evm) A-op-node Area: op-node (go consensus client) A-op-program Area: op-program (go fault-prover) A-op-reth Area: op-reth (rust execution client) A-spec Area: spec H-isthmus Hardfork: change is planned for Isthmus upgrade H-pectra Hardfork: change planned for Pectra (L1) upgrade M-tracking Meta: tracking issue U-node Upgrade: involving changes to node component (cl, el, etc.) U-smart-contract Upgrade: involving changes to smart contracts

Comments

@emhane
Copy link
Member

emhane commented Jan 23, 2025

@emhane emhane added U-node Upgrade: involving changes to node component (cl, el, etc.) A-op-program Area: op-program (go fault-prover) H-isthmus Hardfork: change is planned for Isthmus upgrade H-pectra Hardfork: change planned for Pectra (L1) upgrade A-spec Area: spec A-kona Area: kona (rust fault prover) A-op-reth Area: op-reth (rust execution client) A-op-geth Area: op-geth (go execution client incl. go evm) labels Jan 23, 2025
@emhane
Copy link
Member Author

emhane commented Jan 23, 2025

@danyalprout @meyer9 could you open and link the issues for implementing this eip pls

@emhane emhane added M-tracking Meta: tracking issue U-smart-contract Upgrade: involving changes to smart contracts labels Jan 23, 2025
@emhane
Copy link
Member Author

emhane commented Jan 29, 2025

same here, this is done if go is done cc @meyer9

@meyer9
Copy link

meyer9 commented Jan 30, 2025

Yep, this exists here, and is activated by Prague: https://github.com/meyer9/op-geth/blob/12e8db89e0048165586260193a840a63aaf5a722/core/state_processor.go#L88

@emhane
Copy link
Member Author

emhane commented Jan 30, 2025

what about op-program, do you know @clabby ? and does anything have to be done by solidity devs ? or at least we have to deploy same contract as l1 has, right (this would require platforms team engagement) ?

@emhane emhane added the M-platform M: platform development label Jan 31, 2025
@meyer9
Copy link

meyer9 commented Feb 4, 2025

2935 should be created via network upgrade tx here: ethereum-optimism/optimism#14110

@emhane emhane added A-op-node Area: op-node (go consensus client) and removed M-platform M: platform development labels Feb 6, 2025
@emhane
Copy link
Member Author

emhane commented Feb 6, 2025

2935 should be created via network upgrade tx here: ethereum-optimism/optimism#14110

aha I see, op-node deploys the pre-deploy. thanks!

@emhane
Copy link
Member Author

emhane commented Feb 7, 2025

does anything need to be done here for op-program @Inphi ?

@Inphi
Copy link

Inphi commented Feb 7, 2025

@emhane No changes are required to the op-program for the Isthmus upgrade. The upgrade change in the program are already inherited from the op-node abstractions.
The op-program changes to use EIP-2935 are a requirement only for interop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-kona Area: kona (rust fault prover) A-op-geth Area: op-geth (go execution client incl. go evm) A-op-node Area: op-node (go consensus client) A-op-program Area: op-program (go fault-prover) A-op-reth Area: op-reth (rust execution client) A-spec Area: spec H-isthmus Hardfork: change is planned for Isthmus upgrade H-pectra Hardfork: change planned for Pectra (L1) upgrade M-tracking Meta: tracking issue U-node Upgrade: involving changes to node component (cl, el, etc.) U-smart-contract Upgrade: involving changes to smart contracts
Projects
None yet
Development

No branches or pull requests

3 participants