Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interop: Add new role for dependency set management #11366

Closed
3 tasks
tynes opened this issue Aug 6, 2024 · 5 comments · Fixed by #11407
Closed
3 tasks

Interop: Add new role for dependency set management #11366

tynes opened this issue Aug 6, 2024 · 5 comments · Fixed by #11407
Assignees

Comments

@tynes
Copy link
Contributor

tynes commented Aug 6, 2024

Overview

The SystemConfigInterop contract manages the interop dependency set. Right now the owner of the SystemConfig can add and remove dependencies. The owner of the SystemConfig is considered the chain operator. We want to allow for a different role to manage the dependency set so that in production the dependency set can be managed by governance rather than the chain operator.

Definition of Done

  • Specs are updated with this new role
    • Could follow this spec, how there is a "Functions" header and subheaders for each function
    • What should this role be called?
  • Source code is implemented
  • Full test coverage
@AmadiMichael
Copy link
Member

The intention here is to have only one authorized caller of each of the 2 functions at a time right? e.g addDependency cannot have multiple authorized callers at once...

@tynes
Copy link
Contributor Author

tynes commented Aug 8, 2024

Yes exactly, just 1 account that can call addDependency/removeDependency that MAY or MAY NOT be different than the owner from Ownable. Then for the standard config definition, the account that can add remove dependencies MUST be the foundation multisig

@AmadiMichael
Copy link
Member

Ah yes thanks, was about to ask that now,
where can i find the foundation multisig address?

@tynes
Copy link
Contributor Author

tynes commented Aug 8, 2024

You can see in the docs here although we do not want to hardcode any addresses, it would be an argument to initialize at deploy time

@AmadiMichael
Copy link
Member

You can see in the docs here although we do not want to hardcode any addresses, it would be an argument to initialize at deploy time

will this be modifiable and if so, by whom?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants