From ce15886c58de3ef2a63a1ce839990dac605d1344 Mon Sep 17 00:00:00 2001 From: Mikael Simberg Date: Fri, 31 May 2024 14:57:18 +0200 Subject: [PATCH 1/2] Add check that user is authenticated with gh before creating release --- scripts/roll_release.sh | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/scripts/roll_release.sh b/scripts/roll_release.sh index 74fc36c2db..8f6ac921fb 100755 --- a/scripts/roll_release.sh +++ b/scripts/roll_release.sh @@ -29,6 +29,11 @@ if ! which gh >/dev/null 2>&1; then exit 1 fi +if ! gh auth status >/dev/null 2>&1; then + echo 'gh is not logged in. Run `gh auth login` to authenticate with your GitHub account, or set `GITHUB_TOKEN` to a token with `public_repo` access. Exiting.' + exit 1 +fi + # Major and minor releases are made directly from master. Patch releases are branched out from the major # and minor releases with a version_X.Y branch. if [[ "${VERSION_PATCH}" -eq 0 ]]; then From 05b1d44e0712409b94ca18b2bc377ce95965a7f7 Mon Sep 17 00:00:00 2001 From: Mikael Simberg Date: Fri, 31 May 2024 14:58:15 +0200 Subject: [PATCH 2/2] Be explicit about repo in release script --- scripts/roll_release.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/roll_release.sh b/scripts/roll_release.sh index 8f6ac921fb..0578cff896 100755 --- a/scripts/roll_release.sh +++ b/scripts/roll_release.sh @@ -15,6 +15,7 @@ set -o errexit +REPO="eth-cscs/DLA-Future" VERSION_MAJOR=$(sed -n 's/project(DLAF VERSION \([0-9]\+\)\.[0-9]\+\.[0-9]\+)/\1/p' CMakeLists.txt) VERSION_MINOR=$(sed -n 's/project(DLAF VERSION [0-9]\+\.\([0-9]\+\)\.[0-9]\+)/\1/p' CMakeLists.txt) VERSION_PATCH=$(sed -n 's/project(DLAF VERSION [0-9]\+\.[0-9]\+\.\([0-9]\+\))/\1/p' CMakeLists.txt) @@ -158,5 +159,6 @@ fi echo "" echo "Creating release." gh release create "${VERSION_FULL_TAG}" \ - --title "${VERSION_TITLE}" \ - --notes "${VERSION_DESCRIPTION}" + --repo "${REPO}" \ + --title "${VERSION_TITLE}" \ + --notes "${VERSION_DESCRIPTION}"