New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brownie cannot find return value. #1360

Open

itsdevbear opened this issue Dec 3, 2021 · 6 comments

itsdevbear commented Dec 3, 2021 •

edited

Loading

Steps to reproduce:

Deploy contract
Execute function call

Confirmed to be an issue with Brownie, if I use web3.py I get the correct return value as expected.

CALL STACK:

Looks like output is correct, but Brownie cannot find it for some reason.

{"output":"0000000000000000000000000000000000000000000000000000000000000006","gasUsed":"0x14a6","time":1107992}

{"pc":0,"op":96,"gas":"0x1ef1","gasCost":"0x3","memory":"0x","memSize":0,"stack":[],"returnData":"0x","depth":1,"refund":0,"opName":"PUSH1","error":""}
{"pc":2,"op":96,"gas":"0x1eee","gasCost":"0x3","memory":"0x","memSize":0,"stack":["0x80"],"returnData":"0x","depth":1,"refund":0,"opName":"PUSH1","error":""}
{"pc":4,"op":82,"gas":"0x1eeb","gasCost":"0xc","memory":"0x","memSize":96,"stack":["0x80","0x40"],"returnData":"0x","depth":1,"refund":0,"opName":"MSTORE","error":""}
{"pc":5,"op":52,"gas":"0x1edf","gasCost":"0x2","memory":"0x","memSize":96,"stack":[],"returnData":"0x","depth":1,"refund":0,"opName":"CALLVALUE","error":""}
{"pc":6,"op":128,"gas":"0x1edd","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x0"],"returnData":"0x","depth":1,"refund":0,"opName":"DUP1","error":""}
{"pc":7,"op":21,"gas":"0x1eda","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x0","0x0"],"returnData":"0x","depth":1,"refund":0,"opName":"ISZERO","error":""}
{"pc":8,"op":96,"gas":"0x1ed7","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x0","0x1"],"returnData":"0x","depth":1,"refund":0,"opName":"PUSH1","error":""}
{"pc":10,"op":87,"gas":"0x1ed4","gasCost":"0xa","memory":"0x","memSize":96,"stack":["0x0","0x1","0xf"],"returnData":"0x","depth":1,"refund":0,"opName":"JUMPI","error":""}
{"pc":15,"op":91,"gas":"0x1eca","gasCost":"0x1","memory":"0x","memSize":96,"stack":["0x0"],"returnData":"0x","depth":1,"refund":0,"opName":"JUMPDEST","error":""}
{"pc":16,"op":80,"gas":"0x1ec9","gasCost":"0x2","memory":"0x","memSize":96,"stack":["0x0"],"returnData":"0x","depth":1,"refund":0,"opName":"POP","error":""}
{"pc":17,"op":96,"gas":"0x1ec7","gasCost":"0x3","memory":"0x","memSize":96,"stack":[],"returnData":"0x","depth":1,"refund":0,"opName":"PUSH1","error":""}
{"pc":19,"op":54,"gas":"0x1ec4","gasCost":"0x2","memory":"0x","memSize":96,"stack":["0x4"],"returnData":"0x","depth":1,"refund":0,"opName":"CALLDATASIZE","error":""}
{"pc":20,"op":16,"gas":"0x1ec2","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x4","0x4"],"returnData":"0x","depth":1,"refund":0,"opName":"LT","error":""}
{"pc":21,"op":96,"gas":"0x1ebf","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x0"],"returnData":"0x","depth":1,"refund":0,"opName":"PUSH1","error":""}
{"pc":23,"op":87,"gas":"0x1ebc","gasCost":"0xa","memory":"0x","memSize":96,"stack":["0x0","0x32"],"returnData":"0x","depth":1,"refund":0,"opName":"JUMPI","error":""}
{"pc":24,"op":96,"gas":"0x1eb2","gasCost":"0x3","memory":"0x","memSize":96,"stack":[],"returnData":"0x","depth":1,"refund":0,"opName":"PUSH1","error":""}
{"pc":26,"op":53,"gas":"0x1eaf","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x0"],"returnData":"0x","depth":1,"refund":0,"opName":"CALLDATALOAD","error":""}
{"pc":27,"op":96,"gas":"0x1eac","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f92200000000000000000000000000000000000000000000000000000000"],"returnData":"0x","depth":1,"refund":0,"opName":"PUSH1","error":""}
{"pc":29,"op":28,"gas":"0x1ea9","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f92200000000000000000000000000000000000000000000000000000000","0xe0"],"returnData":"0x","depth":1,"refund":0,"opName":"SHR","error":""}
{"pc":30,"op":128,"gas":"0x1ea6","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922"],"returnData":"0x","depth":1,"refund":0,"opName":"DUP1","error":""}
{"pc":31,"op":99,"gas":"0x1ea3","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x9476f922"],"returnData":"0x","depth":1,"refund":0,"opName":"PUSH4","error":""}
{"pc":36,"op":20,"gas":"0x1ea0","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x9476f922","0x5c7fdf20"],"returnData":"0x","depth":1,"refund":0,"opName":"EQ","error":""}
{"pc":37,"op":96,"gas":"0x1e9d","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x0"],"returnData":"0x","depth":1,"refund":0,"opName":"PUSH1","error":""}
{"pc":39,"op":87,"gas":"0x1e9a","gasCost":"0xa","memory":"0x","memSize":96,"stack":["0x9476f922","0x0","0x37"],"returnData":"0x","depth":1,"refund":0,"opName":"JUMPI","error":""}
{"pc":40,"op":128,"gas":"0x1e90","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922"],"returnData":"0x","depth":1,"refund":0,"opName":"DUP1","error":""}
{"pc":41,"op":99,"gas":"0x1e8d","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x9476f922"],"returnData":"0x","depth":1,"refund":0,"opName":"PUSH4","error":""}
{"pc":46,"op":20,"gas":"0x1e8a","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x9476f922","0x9476f922"],"returnData":"0x","depth":1,"refund":0,"opName":"EQ","error":""}
{"pc":47,"op":96,"gas":"0x1e87","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x1"],"returnData":"0x","depth":1,"refund":0,"opName":"PUSH1","error":""}
{"pc":49,"op":87,"gas":"0x1e84","gasCost":"0xa","memory":"0x","memSize":96,"stack":["0x9476f922","0x1","0x4d"],"returnData":"0x","depth":1,"refund":0,"opName":"JUMPI","error":""}
{"pc":77,"op":91,"gas":"0x1e7a","gasCost":"0x1","memory":"0x","memSize":96,"stack":["0x9476f922"],"returnData":"0x","depth":1,"refund":0,"opName":"JUMPDEST","error":""}
{"pc":78,"op":96,"gas":"0x1e79","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922"],"returnData":"0x","depth":1,"refund":0,"opName":"PUSH1","error":""}
{"pc":80,"op":96,"gas":"0x1e76","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b"],"returnData":"0x","depth":1,"refund":0,"opName":"PUSH1","error":""}
{"pc":82,"op":96,"gas":"0x1e73","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0"],"returnData":"0x","depth":1,"refund":0,"opName":"PUSH1","error":""}
{"pc":84,"op":128,"gas":"0x1e70","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1"],"returnData":"0x","depth":1,"refund":0,"opName":"DUP1","error":""}
{"pc":85,"op":96,"gas":"0x1e6d","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1"],"returnData":"0x","depth":1,"refund":0,"opName":"PUSH1","error":""}
{"pc":87,"op":130,"gas":"0x1e6a","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0"],"returnData":"0x","depth":1,"refund":0,"opName":"DUP3","error":""}
{"pc":88,"op":130,"gas":"0x1e67","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0","0x1"],"returnData":"0x","depth":1,"refund":0,"opName":"DUP3","error":""}
{"pc":89,"op":84,"gas":"0x1e64","gasCost":"0x834","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0","0x1","0x1"],"returnData":"0x","depth":1,"refund":0,"opName":"SLOAD","error":""}
{"pc":90,"op":96,"gas":"0x1630","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0","0x1","0x8"],"returnData":"0x","depth":1,"refund":0,"opName":"PUSH1","error":""}
{"pc":92,"op":145,"gas":"0x162d","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0","0x1","0x8","0x61"],"returnData":"0x","depth":1,"refund":0,"opName":"SWAP2","error":""}
{"pc":93,"op":144,"gas":"0x162a","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0","0x61","0x8","0x1"],"returnData":"0x","depth":1,"refund":0,"opName":"SWAP1","error":""}
{"pc":94,"op":96,"gas":"0x1627","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0","0x61","0x1","0x8"],"returnData":"0x","depth":1,"refund":0,"opName":"PUSH1","error":""}
{"pc":96,"op":86,"gas":"0x1624","gasCost":"0x8","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0","0x61","0x1","0x8","0x6d"],"returnData":"0x","depth":1,"refund":0,"opName":"JUMP","error":""}
{"pc":109,"op":91,"gas":"0x161c","gasCost":"0x1","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0","0x61","0x1","0x8"],"returnData":"0x","depth":1,"refund":0,"opName":"JUMPDEST","error":""}
{"pc":110,"op":96,"gas":"0x161b","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0","0x61","0x1","0x8"],"returnData":"0x","depth":1,"refund":0,"opName":"PUSH1","error":""}
{"pc":112,"op":130,"gas":"0x1618","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0","0x61","0x1","0x8","0x0"],"returnData":"0x","depth":1,"refund":0,"opName":"DUP3","error":""}
{"pc":113,"op":25,"gas":"0x1615","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0","0x61","0x1","0x8","0x0","0x1"],"returnData":"0x","depth":1,"refund":0,"opName":"NOT","error":""}
{"pc":114,"op":130,"gas":"0x1612","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0","0x61","0x1","0x8","0x0","0xfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffe"],"returnData":"0x","depth":1,"refund":0,"opName":"DUP3","error":""}
{"pc":115,"op":17,"gas":"0x160f","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0","0x61","0x1","0x8","0x0","0xfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffe","0x8"],"returnData":"0x","depth":1,"refund":0,"opName":"GT","error":""}
{"pc":116,"op":21,"gas":"0x160c","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0","0x61","0x1","0x8","0x0","0x0"],"returnData":"0x","depth":1,"refund":0,"opName":"ISZERO","error":""}
{"pc":117,"op":96,"gas":"0x1609","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0","0x61","0x1","0x8","0x0","0x1"],"returnData":"0x","depth":1,"refund":0,"opName":"PUSH1","error":""}
{"pc":119,"op":87,"gas":"0x1606","gasCost":"0xa","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0","0x61","0x1","0x8","0x0","0x1","0x8d"],"returnData":"0x","depth":1,"refund":0,"opName":"JUMPI","error":""}
{"pc":141,"op":91,"gas":"0x15fc","gasCost":"0x1","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0","0x61","0x1","0x8","0x0"],"returnData":"0x","depth":1,"refund":0,"opName":"JUMPDEST","error":""}
{"pc":142,"op":80,"gas":"0x15fb","gasCost":"0x2","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0","0x61","0x1","0x8","0x0"],"returnData":"0x","depth":1,"refund":0,"opName":"POP","error":""}
{"pc":143,"op":1,"gas":"0x15f9","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0","0x61","0x1","0x8"],"returnData":"0x","depth":1,"refund":0,"opName":"ADD","error":""}
{"pc":144,"op":144,"gas":"0x15f6","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0","0x61","0x9"],"returnData":"0x","depth":1,"refund":0,"opName":"SWAP1","error":""}
{"pc":145,"op":86,"gas":"0x15f3","gasCost":"0x8","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0","0x9","0x61"],"returnData":"0x","depth":1,"refund":0,"opName":"JUMP","error":""}
{"pc":97,"op":91,"gas":"0x15eb","gasCost":"0x1","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0","0x9"],"returnData":"0x","depth":1,"refund":0,"opName":"JUMPDEST","error":""}
{"pc":98,"op":144,"gas":"0x15ea","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x0","0x9"],"returnData":"0x","depth":1,"refund":0,"opName":"SWAP1","error":""}
{"pc":99,"op":145,"gas":"0x15e7","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x1","0x9","0x0"],"returnData":"0x","depth":1,"refund":0,"opName":"SWAP2","error":""}
{"pc":100,"op":85,"gas":"0x15e4","gasCost":"0xb54","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x0","0x9","0x1"],"returnData":"0x","depth":1,"refund":0,"opName":"SSTORE","error":""}
{"pc":101,"op":80,"gas":"0xa90","gasCost":"0x2","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x0"],"returnData":"0x","depth":1,"refund":0,"opName":"POP","error":""}
{"pc":102,"op":96,"gas":"0xa8e","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1"],"returnData":"0x","depth":1,"refund":0,"opName":"PUSH1","error":""}
{"pc":104,"op":146,"gas":"0xa8b","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x3b","0x0","0x1","0x6"],"returnData":"0x","depth":1,"refund":0,"opName":"SWAP3","error":""}
{"pc":105,"op":145,"gas":"0xa88","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x6","0x0","0x1","0x3b"],"returnData":"0x","depth":1,"refund":0,"opName":"SWAP2","error":""}
{"pc":106,"op":80,"gas":"0xa85","gasCost":"0x2","memory":"0x","memSize":96,"stack":["0x9476f922","0x6","0x3b","0x1","0x0"],"returnData":"0x","depth":1,"refund":0,"opName":"POP","error":""}
{"pc":107,"op":80,"gas":"0xa83","gasCost":"0x2","memory":"0x","memSize":96,"stack":["0x9476f922","0x6","0x3b","0x1"],"returnData":"0x","depth":1,"refund":0,"opName":"POP","error":""}
{"pc":108,"op":86,"gas":"0xa81","gasCost":"0x8","memory":"0x","memSize":96,"stack":["0x9476f922","0x6","0x3b"],"returnData":"0x","depth":1,"refund":0,"opName":"JUMP","error":""}
{"pc":59,"op":91,"gas":"0xa79","gasCost":"0x1","memory":"0x","memSize":96,"stack":["0x9476f922","0x6"],"returnData":"0x","depth":1,"refund":0,"opName":"JUMPDEST","error":""}
{"pc":60,"op":96,"gas":"0xa78","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x6"],"returnData":"0x","depth":1,"refund":0,"opName":"PUSH1","error":""}
{"pc":62,"op":81,"gas":"0xa75","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x6","0x40"],"returnData":"0x","depth":1,"refund":0,"opName":"MLOAD","error":""}
{"pc":63,"op":144,"gas":"0xa72","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x6","0x80"],"returnData":"0x","depth":1,"refund":0,"opName":"SWAP1","error":""}
{"pc":64,"op":129,"gas":"0xa6f","gasCost":"0x3","memory":"0x","memSize":96,"stack":["0x9476f922","0x80","0x6"],"returnData":"0x","depth":1,"refund":0,"opName":"DUP2","error":""}
{"pc":65,"op":82,"gas":"0xa6c","gasCost":"0x9","memory":"0x","memSize":160,"stack":["0x9476f922","0x80","0x6","0x80"],"returnData":"0x","depth":1,"refund":0,"opName":"MSTORE","error":""}
{"pc":66,"op":96,"gas":"0xa63","gasCost":"0x3","memory":"0x","memSize":160,"stack":["0x9476f922","0x80"],"returnData":"0x","depth":1,"refund":0,"opName":"PUSH1","error":""}
{"pc":68,"op":1,"gas":"0xa60","gasCost":"0x3","memory":"0x","memSize":160,"stack":["0x9476f922","0x80","0x20"],"returnData":"0x","depth":1,"refund":0,"opName":"ADD","error":""}
{"pc":69,"op":96,"gas":"0xa5d","gasCost":"0x3","memory":"0x","memSize":160,"stack":["0x9476f922","0xa0"],"returnData":"0x","depth":1,"refund":0,"opName":"PUSH1","error":""}
{"pc":71,"op":81,"gas":"0xa5a","gasCost":"0x3","memory":"0x","memSize":160,"stack":["0x9476f922","0xa0","0x40"],"returnData":"0x","depth":1,"refund":0,"opName":"MLOAD","error":""}
{"pc":72,"op":128,"gas":"0xa57","gasCost":"0x3","memory":"0x","memSize":160,"stack":["0x9476f922","0xa0","0x80"],"returnData":"0x","depth":1,"refund":0,"opName":"DUP1","error":""}
{"pc":73,"op":145,"gas":"0xa54","gasCost":"0x3","memory":"0x","memSize":160,"stack":["0x9476f922","0xa0","0x80","0x80"],"returnData":"0x","depth":1,"refund":0,"opName":"SWAP2","error":""}
{"pc":74,"op":3,"gas":"0xa51","gasCost":"0x3","memory":"0x","memSize":160,"stack":["0x9476f922","0x80","0x80","0xa0"],"returnData":"0x","depth":1,"refund":0,"opName":"SUB","error":""}
{"pc":75,"op":144,"gas":"0xa4e","gasCost":"0x3","memory":"0x","memSize":160,"stack":["0x9476f922","0x80","0x20"],"returnData":"0x","depth":1,"refund":0,"opName":"SWAP1","error":""}
{"pc":76,"op":243,"gas":"0xa4b","gasCost":"0x0","memory":"0x","memSize":160,"stack":["0x9476f922","0x20","0x80"],"returnData":"0x","depth":1,"refund":0,"opName":"RETURN","error":""}
{"output":"0000000000000000000000000000000000000000000000000000000000000006","gasUsed":"0x14a6","time":1107992}

Member

iamdefinitelyahuman commented Dec 4, 2021

what node client are you using?

Author

itsdevbear commented Dec 4, 2021 •

edited

Loading

@iamdefinitelyahuman Ethermint: https://github.com/tharsis/ethermint

Going to dig into it more later today as well, anything jump out at you off the bat?
I am guessing some weirdness going on here:

import ipdb
ipdb.set_trace()
if opcode == "RETURN":
    returndata = _get_memory(trace[i], -1)
    if returndata:
        fn = last["function"]
        try:
            return_values = fn.decode_output(returndata)
            if len(fn.abi["outputs"]) == 1:
                return_values = (return_values,)
            subcall["return_value"] = return_values
        except Exception:
            subcall["returndata"] = returndata.hex()
    else:
        subcall["return_value"] = None

Author

itsdevbear commented Dec 4, 2021 •

edited

Loading

Camel case vs lowercase? Also unsure if the "output" that the node is outputting is standard.

Author

itsdevbear commented Dec 12, 2021

@iamdefinitelyahuman just checking in to see if you had a chance to look at this. I didn't have much success.

Cheers,
-b

Contributor

sparrowDom commented Dec 18, 2023

I am also experiencing this issue and return data isn't present in the call_trace(True) trace - probably for the same reason

sparrowDom mentioned this issue

Include encoded return data in transaction trace #1715

Merged

4 tasks

Contributor

sparrowDom commented Dec 19, 2023

I've fixed a problem where call_trace wouldn't include the transaction returndata. Fix for it in this PR: #1715

The issue I was experiencing was that brownie doesn't set return_value if it doesn't have enough source code information of the contract.

It could be possible that above change fixes the issue for you as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment