-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge/cleanup Procfiles #15778
Comments
@serathius and @jmhbnz I would like to work on this. |
Let's discuss which option we should do. I don't use procfile as much so I don't want to pick myself. |
Cool. I am doing a bit of digging around. I will get back to you soon and we can go ahead. In the meantime, do you think it might be a good idea to ask around in the etcd channel if other contributors have any opinions on this as well? |
Sure, cc @ahrtr @ptabor @jmhbnz @chaochn47 @lavacat |
|
Suggested approach from @ahrtr sounds good to me. That would cut two files out of root directory which is a great win. |
Based on the inputs provided by everyone, I will make the changes and create a PR. |
Hey @sharathsivakumar are you still able to work on this? If not that is ok just let us know so we can reassign it. If you're stuck or have any questions please reach out to me on kubernetes slack or reply here. Thanks! 🙏🏻 |
Thanks for your pull request @shivanshu1333, I've reassigned the issue to you. This issue was originally assigned to another contributor, so in future from a contributor experience perspective my preference would be for you to check in with the assigned contributor first and ask for them to release the issue before raising a pr. |
Thanks @jmhbnz and apologies, suggestion noted! |
What would you like to be added?
Procfiles are nice and all, but why do we need to have 3 in root directory
Procfile
,Procfile.learner
,Procfile.v2
.I propose one of three things:
Procfile.learner
andProcfile.v2
so onlyProcfile
is left.Documentation/contributor-guide
or similar place for contributors.Why is this needed?
Root directory should be minimal to improve readability and avoid overwhelming new contributors.
It's not clear which one of them they should use, nor where it is documented.
The text was updated successfully, but these errors were encountered: