Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor directory for grpc seems incomplete - go get etcd fails without go modules #11553

Closed
dfawley opened this issue Jan 22, 2020 · 5 comments
Closed

Comments

@dfawley
Copy link

dfawley commented Jan 22, 2020

$ go get go.etcd.io/etcd
/usr/local/google/home/dfawley/go/src/go.etcd.io/etcd/vendor/google.golang.org/grpc/balancer_conn_wrappers.go:28:2: use of internal package not allowed
/usr/local/google/home/dfawley/go/src/go.etcd.io/etcd/vendor/google.golang.org/grpc/clientconn.go:49:2: use of internal package not allowed
/usr/local/google/home/dfawley/go/src/go.etcd.io/etcd/vendor/google.golang.org/grpc/clientconn.go:50:2: use of internal package not allowed

I believe this is happening because grpc was updated to a new version recently, but some files were omitted from new directories, e.g. grpc/internal/buffer and grpc/internal/resolver/{dns,passthrough}.

@dfawley
Copy link
Author

dfawley commented Jan 22, 2020

Note that you will also need to set GO111MODULE=off to reproduce this issue if using a recent version of go.

@spzala
Copy link
Member

spzala commented Jan 22, 2020

@dfawley thanks for reporting! We have couple of other similar issues reported around it and briefly discussed it there like #11532 We should have it resolved soon.

@dfawley
Copy link
Author

dfawley commented Jan 23, 2020

Thanks for following up. Looks like this is indeed a dupe of #11532, so I'll close this one.

@dfawley dfawley closed this as completed Jan 23, 2020
@spzala
Copy link
Member

spzala commented Jan 23, 2020

@dfawley you are welcome, and thanks for closing it!

@spzala
Copy link
Member

spzala commented Jan 29, 2020

@dfawley fyi, this should be fixed under #11557 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants