Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-proxy: listenAddr/metrics exposes metrics of proxy -> endpoint not etcd server endpoint. #10611

Closed
hexfusion opened this issue Apr 4, 2019 · 0 comments · Fixed by #10618

Comments

@hexfusion
Copy link
Contributor

hexfusion commented Apr 4, 2019

etcd grpc-proxy --listen-addr HandleHealth handler returns /health of the endpoint but HandlePrometheus /metrics endpoint returns metrics of the proxy itself. I feel this is a bug. We have a separate flag to expose proxy metrics --metrics-addr.

etcd/etcdmain/grpc_proxy.go

Lines 328 to 332 in 627cffd

func mustHTTPListener(m cmux.CMux, tlsinfo *transport.TLSInfo, c *clientv3.Client) (*http.Server, net.Listener) {
httpmux := http.NewServeMux()
httpmux.HandleFunc("/", http.NotFound)
etcdhttp.HandlePrometheus(httpmux)
grpcproxy.HandleHealth(httpmux, c)

@hexfusion hexfusion self-assigned this Apr 4, 2019
@hexfusion hexfusion changed the title grpc-proxy: listenAddr/metrics exposes metrics of proxy -> endpoint not endpoint. grpc-proxy: listenAddr/metrics exposes metrics of proxy -> endpoint not etcd server endpoint. Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant