Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genproto.sh script is broken #10336

Closed
gyuho opened this issue Dec 18, 2018 · 3 comments · Fixed by #10424
Closed

genproto.sh script is broken #10336

gyuho opened this issue Dec 18, 2018 · 3 comments · Fixed by #10424
Assignees

Comments

@gyuho
Copy link
Contributor

gyuho commented Dec 18, 2018

$ ./scripts/genproto.sh
go: finding github.com/gogo/protobuf v1.0.0
go: finding github.com/gogo/protobuf/protoc-gen-gogo latest
go: finding github.com/gogo/protobuf/proto latest
go: finding github.com/gogo/protobuf/gogoproto latest
go: finding golang.org/x/tools/cmd/goimports latest
go: finding golang.org/x/tools/cmd latest
go: finding golang.org/x/tools latest
./scripts/genproto.sh: line 46: pushd: /home/leegyuho/go/src/go.etcd.io/etcd/gopath.proto/src/github.com/gogo/protobuf: No such file or directory

Even with workaround (disable git reset && install), it still fails with newest gRPC gateway plugin:

go: downloading gopkg.in/yaml.v2 v2.2.1
# github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway/descriptor
gopath.proto/pkg/mod/github.com/grpc-ecosystem/grpc-gateway@v1.6.2/protoc-gen-grpc-gateway/descriptor/services.go:146:49: opts.ResponseBody undefined (type *annotations.HttpRule has no field or method ResponseBody)

Reproducible both in OS X and Linux.

@hexfusion @jingyih Can you take a look?

@gyuho
Copy link
Contributor Author

gyuho commented Dec 18, 2018

Also protoc v3.6.1 has been released https://github.com/protocolbuffers/protobuf/releases/tag/v3.6.1. We should bump up to protoc version in that script.

@hexfusion hexfusion self-assigned this Dec 18, 2018
@hexfusion
Copy link
Contributor

@gyuho GO111MODULE=off scripts/genproto.sh. Does that work? I have played with 3.5.1+ and the swagger output is a mess. I will take a deeper look.

@@ -260,11 +260,11 @@
     },
     "/v3alpha/auth/user/add": {
       "post": {
-        "summary": "UserAdd adds a new user.",
+        "summary": "Txn processes multiple requests in a single transaction.\nA txn request increments the revision of the key-value store\nand generates events with the same revision for every completed request.\nIt is not allowed to modify the same key several times within one txn.",
         "operationId": "UserAdd",
         "responses": {
           "200": {
-            "description": "",
+            "description": "A successful response.",
             "schema": {
               "$ref": "#/definitions/etcdserverpbAuthUserAddResponse"
             }

@hexfusion
Copy link
Contributor

Fairly certain the comment issue is caused upstream by grpc-ecosystem/grpc-gateway#746. Will review/resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants