Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[discussion] compatibility with other plugins related to remark #180

Closed
JounQin opened this issue Mar 18, 2021 · 1 comment
Closed

[discussion] compatibility with other plugins related to remark #180

JounQin opened this issue Mar 18, 2021 · 1 comment
Labels
triage

Comments

@JounQin
Copy link
Contributor

JounQin commented Mar 18, 2021 •
edited
Loading

@btmills Hi, #179 is not related, at this PR actually only adds blocksCache and getShortLang and better TypeScript support.

For blocksCache, it is actually an issue described at #178 (comment)

For getShortLang, it fixes #176

For ts typings generated by typescript + jsdoc, it will be easier to be resued in eslint-mdx. I can just copy-paste the source code of eslint-plugin-markdown into https://github.com/mdx-js/eslint-mdx/blob/master/packages/eslint-plugin-mdx/src/processors/markdown.ts for now.

I added eslint-plugin-mdx as dev dep just to make sure they are working compatibly.

Originally posted by @JounQin in #178 (comment)
@JounQin JounQin mentioned this issue Mar 18, 2021
Closed
@JounQin
Copy link
Contributor Author

JounQin commented Mar 18, 2021

continue to discuss on PR instead

@JounQin JounQin closed this as completed Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update: compatibility with eslint-mdx
1 participant
@JounQin