We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v
As discussed in ethereum/yellowpaper#860 the ecrecover precompile only allows v={27,28} and no other value.
v={27,28}
The precompile code (here) calls ecdsa::is_valid_signature to check r/s values and ecdsa::v_to_y_parity_and_chain_id to retrieve the v value.
r
s
This latter seems to silently allow EIP-155 style v values too, which would be against the spec.
The text was updated successfully, but these errors were encountered:
It's not a problem because later the precompile rejects EIP-155 values.
Sorry, something went wrong.
Oh you mean the parity_and_id->chain_id != std::nullopt part? Yeah, it is a bit confusing, but I see all of this has been rewritten/reworked now.
parity_and_id->chain_id != std::nullopt
No branches or pull requests
As discussed in ethereum/yellowpaper#860 the ecrecover precompile only allows
v={27,28}
and no other value.The precompile code (here) calls ecdsa::is_valid_signature to check
r
/s
values and ecdsa::v_to_y_parity_and_chain_id to retrieve thev
value.This latter seems to silently allow EIP-155 style
v
values too, which would be against the spec.The text was updated successfully, but these errors were encountered: