Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all Promises are created equal #64

Closed
iamdustan opened this issue Aug 10, 2015 · 1 comment
Closed

Not all Promises are created equal #64

iamdustan opened this issue Aug 10, 2015 · 1 comment
Milestone

Comments

@iamdustan
Copy link
Contributor

Currently the Resolver tests that a @resolve Promise is instanceof Promise. Promises seem to be a bit fickle in that there are many different implementations and ways to get a global Promise object.

A few possibilities:

The question is should we expect one global Promise object or provide a duckpunch to interop with the different methods?

Alternatively, we could ignore Promises and use a callback which the consumer is responsible for calling in whatever async control flow implementation they should choose.

@ericclemmons ericclemmons added this to the v2 milestone Aug 11, 2015
@ericclemmons
Copy link
Owner

This is being resolved in #65 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants