Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for PR#614 #1

Open
wants to merge 11 commits into
base: winterwx
Choose a base branch
from
Open

Updates for PR#614 #1

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
177281f
remove unused RUC LSM variable and change some CCPP standard names
Jan 11, 2023
1edb6c5
address standard name clash with lwe_of_surface... variables
grantfirl Jan 12, 2023
201aecd
update atmos_cubed_sphere submodule pointer
grantfirl Jan 12, 2023
5994747
Merge branch 'winterwx' into winterwx_gjf
grantfirl Jan 13, 2023
f0fbd73
add back internal RUC LSM surface frozen precip density
grantfirl Jan 18, 2023
4edd5eb
update ccpp/physics submodule pointer
grantfirl Jan 19, 2023
cb910d0
change vrbliceden_noah to exticeden
grantfirl Jan 20, 2023
4e8ff4e
fix compilation error in GFS_typedefs.F90
grantfirl Jan 20, 2023
0f82064
fix another error in GFS_typedefs.F90
grantfirl Jan 20, 2023
416f96e
point to Eric's latest winterwx branch of ccpp/physics
grantfirl Jan 27, 2023
a168cf5
Merge branch 'winterwx' into winterwx_gjf
grantfirl Jan 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ccpp/data/CCPP_typedefs.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1700,7 +1700,7 @@
type = real
kind = kind_phys
[fullradar_diag]
standard_name = flag_for_computing_full_radar_reflectivity
standard_name = do_full_radar_reflectivity
long_name = flag for computing full radar reflectivity
units = flag
dimensions = ()
Expand Down
3 changes: 0 additions & 3 deletions ccpp/data/GFS_typedefs.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,6 @@ module GFS_typedefs
real (kind=kind_phys), pointer :: clw_surf_ice(:) => null() !< RUC LSM: moist cloud water mixing ratio at surface over ice
real (kind=kind_phys), pointer :: qwv_surf_land(:) => null() !< RUC LSM: water vapor mixing ratio at surface over land
real (kind=kind_phys), pointer :: qwv_surf_ice(:) => null() !< RUC LSM: water vapor mixing ratio at surface over ice
real (kind=kind_phys), pointer :: rhofr(:) => null() !< RUC LSM: density of frozen precipitation
real (kind=kind_phys), pointer :: tsnow_land(:) => null() !< RUC LSM: snow temperature at the bottom of the first snow layer over land
real (kind=kind_phys), pointer :: tsnow_ice(:) => null() !< RUC LSM: snow temperature at the bottom of the first snow layer over ice
real (kind=kind_phys), pointer :: snowfallac_land(:) => null() !< ruc lsm diagnostics over land
Expand Down Expand Up @@ -2428,7 +2427,6 @@ subroutine sfcprop_create (Sfcprop, IM, Model)
allocate (Sfcprop%clw_surf_ice (IM))
allocate (Sfcprop%qwv_surf_land (IM))
allocate (Sfcprop%qwv_surf_ice (IM))
allocate (Sfcprop%rhofr (IM))
allocate (Sfcprop%tsnow_land (IM))
allocate (Sfcprop%tsnow_ice (IM))
allocate (Sfcprop%snowfallac_land (IM))
Expand All @@ -2444,7 +2442,6 @@ subroutine sfcprop_create (Sfcprop, IM, Model)
Sfcprop%qwv_surf_land = clear_val
Sfcprop%qwv_surf_ice = clear_val
Sfcprop%flag_frsoil = clear_val
Sfcprop%rhofr = clear_val
Sfcprop%tsnow_land = clear_val
Sfcprop%tsnow_ice = clear_val
Sfcprop%snowfallac_land = clear_val
Expand Down
24 changes: 8 additions & 16 deletions ccpp/data/GFS_typedefs.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1627,14 +1627,6 @@
type = real
kind = kind_phys
active = (control_for_land_surface_scheme == identifier_for_ruc_land_surface_scheme)
[rhofr]
standard_name = frozen_precipitation_density
long_name = density of frozen precipitation
units = kg m-3
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
active = (control_for_land_surface_scheme == identifier_for_ruc_land_surface_scheme)
[tsnow_land]
standard_name = temperature_in_surface_snow_at_surface_adjacent_layer_over_land
long_name = snow temperature at the bottom of the first snow layer over land
Expand Down Expand Up @@ -4171,7 +4163,7 @@
dimensions = ()
type = integer
[vrbliceden_noah]
standard_name = flag_for_vrbl_prcp_ice_den
standard_name = do_variable_surface_frozen_precipitation_density
long_name = flag for variable precip ice density
units = flag
dimensions = ()
Expand Down Expand Up @@ -7512,49 +7504,49 @@
type = real
kind = kind_phys
[frzr]
standard_name = lwe_thickness_of_sfc_freezing_rain_amount
standard_name = cumulative_lwe_thickness_of_surface_freezing_rain_amount
long_name = accumulated surface freezing rain
units = m
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
[frzrb]
standard_name = lwe_thickness_of_sfc_freezing_rain_amount_in_bucket
standard_name = cumulative_lwe_thickness_of_surface_freezing_rain_amount_in_bucket
long_name = accumulated surface freezing rain in bucket
units = m
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
[frozr]
standard_name = lwe_thickness_of_sfc_graupel_amount
standard_name = cumulative_lwe_thickness_of_surface_graupel_amount
long_name = accumulated surface graupel
units = m
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
[frozrb]
standard_name = lwe_thickness_of_sfc_graupel_amount_in_bucket
standard_name = cumulative_lwe_thickness_of_surface_graupel_amount_in_bucket
long_name = accumulated surface graupel in bucket
units = m
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
[tsnowp]
standard_name = lwe_thickness_of_sfc_snow_amount
standard_name = cumulative_lwe_thickness_of_surface_snow_amount
long_name = accumulated surface snow
units = m
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
[tsnowpb]
standard_name = lwe_thickness_of_sfc_snow_amount_in_bucket
standard_name = cumulative_lwe_thickness_of_surface_snow_amount_in_bucket
long_name = accumulated surface snow in bucket
units = m
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
[rhonewsn1]
standard_name = lwe_density_of_precip_ice
standard_name = surface_frozen_precipitation_density
long_name = density of precipitation ice
units = kg m-3
dimensions = (horizontal_loop_extent)
Expand Down