From 9ad58ff3f90fe19af9519d112eec54a74d74d6bf Mon Sep 17 00:00:00 2001 From: Martin Alfke Date: Thu, 21 May 2015 10:31:41 +0200 Subject: [PATCH] make onevnet_name a required parameter and fail in case that the parameter is not given adopt spec tests to new attribute requirement --- lib/puppet/type/onevnet_addressrange.rb | 4 ++++ spec/type/onevnet_addressrange_spec.rb | 1 + 2 files changed, 5 insertions(+) diff --git a/lib/puppet/type/onevnet_addressrange.rb b/lib/puppet/type/onevnet_addressrange.rb index 5f50e617..812411e6 100644 --- a/lib/puppet/type/onevnet_addressrange.rb +++ b/lib/puppet/type/onevnet_addressrange.rb @@ -83,4 +83,8 @@ self[:onevnet_name] end + validate do + raise Puppet::Error, 'Onevnet name is required' unless self[:onevnet_name].nil? + end + end diff --git a/spec/type/onevnet_addressrange_spec.rb b/spec/type/onevnet_addressrange_spec.rb index c622fff4..7eb326bf 100644 --- a/spec/type/onevnet_addressrange_spec.rb +++ b/spec/type/onevnet_addressrange_spec.rb @@ -22,6 +22,7 @@ before :each do @vnet = res_type.new(:name => 'test') + @onevnet_name = res_type.new(:name => 'test') @vnet4 = res_type.new(:name => 'test') @vnet6 = res_type.new(:name => 'test') end