-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functionality to support users with modelr::data_grid
into newdata
#280
Comments
I think ideally it would dispatch on the class of the model people have used |
I also would be surprised if that as.data.frame was actually needed? |
I think it's needed currently but I don't think that it should be needed. |
Yes I agree. Given that the parts that are required are the LHS of the formula which are model specific. It could be that in future we allow users to "predict without censoring" using a different model in a different way than by setting window variables to zero. |
Flagging that I'm using these code snippets, and I think would be good to have this as feature in the package (with dispatch on model class). |
The workflow (see #52) we have for creating
newdata
(that goes intotidybayes
) is:Perhaps we want to support users to do this somehow?
Maybe just the mutation part? It could have options to specify e.g. "no censoring" or "no truncation" rather than having to know what to do yourself? (But also we should make it more obvious via the names.)
The text was updated successfully, but these errors were encountered: