TypeError: cannot unpack non-iterable IFDRational object #13
Comments
|
Hi @Mobi97213, I didn't try this on another Ubuntu distro than 18.04, thank you for pointing me about the Ceres solver. Seems that you have problems with the focal lengths, did you update the |
|
from def extract_focal_length(images=[], scale=1.0, verbose=False):
"""Extracts (pixel) focal length from images where available.
The functions returns a dictionary of image, focal length pairs.
If no focal length is extracted for an image, the second pair is None.
"""
if len(images) == 0:
if verbose: print("[- Creating list of images -]")
images = get_images()
ret = {}
for image in images:
if verbose: print("[Extracting EXIF tags from image {0}]".format(image))
tags = {}
with open(image, 'rb') as fp:
img = Image.open(fp)
if hasattr(img, '_getexif'):
exifinfo = img._getexif()
if exifinfo is not None:
for tag, value in exifinfo.items():
tags[ExifTags.TAGS.get(tag, tag)] = value
ret[image] = None
# Extract Focal Length
focalN, focalD = tags.get('FocalLength', (0, 1))
focal_length = float(focalN)/float(focalD)
# Extract Resolution
img_width = tags.get('ExifImageWidth', 0)
img_height = tags.get('ExifImageHeight', 0)
if img_width < img_height:
img_width,img_height = img_height,img_widthYou may have missing or incomplete metadata in your images. From the line: focalN, focalD = tags.get('FocalLength', (0, 1))I can say if Could you add the |
|
`rick@BusterBean:~/Downloads/Linux-Photogrametry-Tools/lpt-v0.1.0$ make LOGFILE=/home/rick/lpt.log IMG_DIR=/home/rick/Pictures/Photogrammetry/1-Originals/ Copying files... OK NOTE: The lpt.log file requested on the make line is not created at this point.` |
If I understand correctly, the line I would try to run the program with the Kermit dataset, if that works, then the problem is in the metadata of your pictures. If not, maybe something changed in recent PIL versions and I should investigate. |
|
My command line, pointing to kermit, is: My results are: My conclusion is: My platform was updated to Kubuntu 23.04 today. |
|
My version of Python3 is: Exiftool tells me the first kermit file has metadata talking about focal info: ---- ExifIFD ---- Do you know what metadata fields are being used that causes an error. I'm stopped investigating at this point, not knowing where to look next. |
|
Interesting, I conclude that the changes in I should investigate and adapt the script to work with newer PIL versions. In the meantime you can try installing an old PIL version in a virtualenv or something like that. EDIT: I think the breaking change was introduced here https://github.com/python-pillow/Pillow/pull/6748/files |
I don't know how to fix this... Should I just bail on this tool and find something else?
My Google searches suggest this is a coding error. The NONE result can not be assigned to a variable.
Extracting focal distances...Traceback (most recent call last):
File "/home/rick/Downloads/Linux-Photogrametry-Tools/lpt-v0.1.0/work_dir/bundler.py", line 388, in
images = extract_focal_length(verbose=args.verbose)
File "/home/rick/Downloads/Linux-Photogrametry-Tools/lpt-v0.1.0/work_dir/bundler.py", line 98, in extract_focal_length
focalN, focalD = tags.get('FocalLength', (0, 1))
TypeError: cannot unpack non-iterable IFDRational object
make: *** [Makefile:27: bundler] Error 1
My environment:
Ubuntu 22.10 soon to upgrade to 23.04 next month.
Python 3.10.7
I had to change libceres1 to libceres3 on the following install...
sudo apt install build-essential libjpeg62 liblapack3 libceres3 jhead python3 python3-pil python3-ruamel.yaml
build-essential is already the newest version (12.9ubuntu3).
libjpeg62 is already the newest version (1:6b2-3).
liblapack3 is already the newest version (3.10.1-2).
libceres3 is already the newest version (2.1.0+really2.1.0+dfsg-1).
jhead is already the newest version (1:3.06.0.1-2).
python3 is already the newest version (3.10.6-1).
python3-pil is already the newest version (9.2.0-1).
python3-ruamel.yaml is already the newest version (0.17.16-1).
The text was updated successfully, but these errors were encountered: