Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor http-max-response-time-ms for complete http request #819

Closed
heifner opened this issue Aug 16, 2022 · 0 comments · Fixed by AntelopeIO/leap#96
Closed

Honor http-max-response-time-ms for complete http request #819

heifner opened this issue Aug 16, 2022 · 0 comments · Fixed by AntelopeIO/leap#96
Labels
OCI OCI working this issue... planning Propose change to milestone in next planning meeting
Milestone

Comments

@heifner
Copy link
Member

heifner commented Aug 16, 2022

Currently http-max-response-time-ms is enforced only for the time required to convert the http response to JSON. Many/most http requests such as /v1/chain/get_table_rows have hard-coded time restrictions of 10ms.

Change all http requests to honor http-max-response-time-ms for complete time for handling the http request including time to retrieve data and convert to JSON.

This will give greater control to API operators and also allow locally running nodeos to set unlimited time. Note, however, if allowed to set to large values this can impact block production window times and speculative execution of incoming blocks. A node operator could set http-max-response-time-ms to a large value and then tie up the main thread for large amounts of time handling http requests impacting block production and block validation.

Related EOSIO/eos#10560

@heifner heifner added the planning Propose change to milestone in next planning meeting label Aug 16, 2022
@stephenpdeos stephenpdeos moved this to Todo in ENF Engineering Aug 16, 2022
@heifner heifner added the OCI OCI working this issue... label Aug 30, 2022
@stephenpdeos stephenpdeos added this to the Mandel 3.2.0 milestone Sep 8, 2022
Repository owner moved this from Todo to Done in ENF Engineering Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI OCI working this issue... planning Propose change to milestone in next planning meeting
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants