Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default transaction-retry-max-expiration-sec from 90 to 120 #800

Closed
aaroncox opened this issue Aug 9, 2022 · 0 comments · Fixed by #809 or #810
Closed

Increase default transaction-retry-max-expiration-sec from 90 to 120 #800

aaroncox opened this issue Aug 9, 2022 · 0 comments · Fixed by #809 or #810
Assignees

Comments

@aaroncox
Copy link
Contributor

aaroncox commented Aug 9, 2022

I'm petitioning for this small change to this default parameter.

("transaction-retry-max-expiration-sec", bpo::value<uint32_t>()->default_value(90),
"Maximum allowed transaction expiration for retry transactions, will retry transactions up to this value.")

I'd like to see it increased from 90 to 120, to match the default expiration that many apps have baked into their transactions these days. Any app using the eosio-core SDK by default is going to create transactions that have a 120 expiration, if no expiration is specified.

https://github.com/greymass/eosio-core/blob/35bf93146b7b25203c21e69c14351810dca41e66/src/api/v1/types.ts#L330

If the developers swap from push_transaction to send_transaction2 and intend on using the retry feature, they'll have to then go back and change the expiration as well once they get the error (which isn't super intuitive). So long as there's no major concerns with a 120 default, for ease of developer adoption I'd say we should align these numbers and make the default 120 in nodeos.

@heifner heifner moved this to Todo in ENF Engineering Aug 10, 2022
@stephenpdeos stephenpdeos added the planning Propose change to milestone in next planning meeting label Aug 10, 2022
@stephenpdeos stephenpdeos added this to the Mandel 3.1.0 milestone Aug 10, 2022
@stephenpdeos stephenpdeos removed the planning Propose change to milestone in next planning meeting label Aug 10, 2022
@arhag arhag moved this from Todo to Reviewer Approved in ENF Engineering Aug 10, 2022
Repository owner moved this from Reviewer Approved to Done in ENF Engineering Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment