Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.1.0-RC2 stops syncing #788

Closed
heifner opened this issue Aug 5, 2022 · 0 comments · Fixed by #757
Closed

3.1.0-RC2 stops syncing #788

heifner opened this issue Aug 5, 2022 · 0 comments · Fixed by #757
Assignees
@heifner
Labels
OCI OCI working this issue...
Milestone
Mandel 3.1.0-rc3

Comments

@heifner
Copy link
Member

heifner commented Aug 5, 2022 •
edited
Loading

Reported by @matthewdarwin.

received go_away_message, reason = duplicate reported when not a duplicate.
duplicate connections are never retried, so node stops syncing because it only was connected to the one peer.
@heifner heifner self-assigned this Aug 5, 2022
@heifner heifner added the OCI OCI working this issue... label Aug 5, 2022
heifner referenced this issue Aug 5, 2022
@heifner
GH-755 Attempt connection retries for duplicate connections to handle…
efba1a9 
… corner case of one side disconnecting as a duplicate simply because it had not yet closed its end of the connection.
@heifner heifner mentioned this issue Aug 5, 2022
Merged
heifner referenced this issue Aug 5, 2022
@heifner
Merge pull request #756 from eosnetworkfoundation/GH-755-dup-sync-issue
f63346e 
[3.1] Attempt connection retries for duplicate connections
heifner referenced this issue Aug 5, 2022
@heifner
Merge remote-tracking branch 'origin/release/3.1.x' into GH-755-merge…
dc5c8bc 
…-to-main
@heifner heifner mentioned this issue Aug 5, 2022
Merged
@heifner heifner closed this as completed Aug 5, 2022
arhag referenced this issue Aug 6, 2022
@arhag
Merge pull request #757 from eosnetworkfoundation/GH-755-merge-to-main
7466a35 
[3.1 -> main] Attempt connection retries for duplicate connections
@ericpassmore ericpassmore transferred this issue from eosnetworkfoundation/mandel Aug 6, 2022
@ericpassmore ericpassmore transferred this issue from another repository Aug 6, 2022
@stephenpdeos stephenpdeos added this to the Mandel 3.1.0-rc3 milestone Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
OCI OCI working this issue...
Projects
ENF Engineering
Status: Done
Milestone
Mandel 3.1.0-rc3
Development

Successfully merging a pull request may close this issue.

[3.1 -> main] Attempt connection retries for duplicate connections eosnetworkfoundation/mandel
2 participants
@heifner @stephenpdeos