Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify flake threshold for hotrestart_handoff_test #33966

Merged
merged 2 commits into from
May 10, 2024

Actually *lower* the value instead.

7668d1b
Select commit
Loading
Failed to load commit list.
Merged

Modify flake threshold for hotrestart_handoff_test #33966

Actually *lower* the value instead.
7668d1b
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/TSAN skipped May 9, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/33966/main@7668d1b)

ravenblackx @ravenblackx 7668d1b #33966 merge main@1ffd452

Increase flake threshold for hotrestart_handoff_test

Commit Message: Increase flake threshold for hotrestart_handoff_test
Additional Description: #33251 appears to be a racy flake due to tsan runs being slower. This adjustment is hopefully enough to keep it from flaking. If it continues to flake, it's probably worth considering making this test skipped for *san tests rather than increasing the tolerance any further, since integration tests don't really benefit much from *san anyway.
Risk Level: None, test-only.
Testing: Yes it is.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Environment

Request variables

Key Value
ref 8c86d29
sha 7668d1b
pr 33966
base-sha 1ffd452
actor ravenblackx @ravenblackx
message Increase flake threshold for hotrestart_handoff_test...
started 1715276675.190769
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 31
patch 0
dev true