c-ares: add option for udp_max_queries #33551
Merged
CI (Envoy) / Envoy/macOS
succeeded
Apr 29, 2024 in 5m 49s
Envoy/macOS (success)
Check has finished
Details
Check run finished (success ✔️)
The check run can be viewed here:
Envoy/macOS (pr/33551/main@392cc7e)
Check started by
Request (pr/33551/main@392cc7e)
@deveshkandpal1224
392cc7e
#33551
merge
main@81c6142
c-ares: add option for udp_max_queries
Commit Message: Provides an option to set
udp_max_queries
inDNSResolverOptions
to limit max UDP queries.
Additional Description: This change does following:
- Implements the fix in this version of c-ares library that has been raised in this comment.
- Updates c-ares library to
1.20
to get access to the required change in the library.- Updates
resolver.proto
to expose the option to passudp_max_queries
which can then be passed toc-ares
.- Updates dirty_channel status check logic to conditionally check for status ==
ARES_EREFUSED
without whichDestroyChannelOnRefused
andCustomResolverValidAfterChannelDestruction
test fail after upgrading the c-ares library to1.20
- Adds a unit test to validate that when
udp_max_queries
is set,ARES_OPT_UDP_MAX_QUERIES
flag is set as well.Risk Level: Low
Testing: Unit test
Docs Changes: n/a
Release Notes: updated
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]
Environment
Request variables
Key | Value |
---|---|
ref | dceddcb |
sha | 392cc7e |
pr | 33551 |
base-sha | 81c6142 |
actor | |
message | c-ares: add option for udp_max_queries... |
started | 1714356327.489532 |
target-branch | main |
trusted | false |
Build image
Container image/s (as used in this CI run)
Key | Value |
---|---|
default | envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
mobile | envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
Version
Envoy version (as used in this CI run)
Key | Value |
---|---|
major | 1 |
minor | 31 |
patch | 0 |
dev | true |
Loading