Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: ability to change rate limit descriptor key generated by generic_key action #12702

Closed
Pchelolo opened this issue Aug 18, 2020 · 1 comment · Fixed by #12734
Closed

Comments

@Pchelolo
Copy link
Contributor

Rational

The generic_key rate limit action allows to set a descriptor value to a configured value, however the key is always "generic_key". This makes the ratelimit service config less expressive. Descriptor (generic_key: route_name_XXX) looks much less expressive then descriptor (route_name: XXX)

Proposal

Add optional descriptor_key string property to the generic_key action. If set, it would hold the descriptor key. If not, default to 'generic_key' key.

We would provide the implementation/testing, seeking comments/approval of the proposal.

@mattklein123
Copy link
Member

SGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants