Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: securing admin endpoint #11082

Closed
cstrahan opened this issue May 6, 2020 · 1 comment
Closed

proposal: securing admin endpoint #11082

cstrahan opened this issue May 6, 2020 · 1 comment

Comments

@cstrahan
Copy link
Contributor

cstrahan commented May 6, 2020

A proposal to secure the admin endpoint

I was chatting with @mattklein123 a couple weeks ago about securing the admin endpoint, under the assumption that we'd want some way to allow users to specify arbitrary filters (e.g. RBAC).

I would like to propose that we allow specifying a Listener config in the Admin message, and deprecate the Admin fields that can be taken directly from the Listener (e.g. address details).

The AdminFilter would be made a first class filter (registered with just like the other http filters), but we would validate that the AdminFilter is only used within the Admin config, and that the filter is specified last in the filter chain.

I would appreciate feedback from both Envoy users and developers; would this approach work for you?

@cstrahan cstrahan changed the title proposal: admin proposal: securing admin endpoint May 6, 2020
@htuch
Copy link
Member

htuch commented May 6, 2020

This dupes #2763, can you continue the discussion there? Suggest copy+paste ^^. Thanks.

@htuch htuch closed this as completed May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants