diff --git a/tools/code_format/check_format.py b/tools/code_format/check_format.py index 20345e43d953..c9f96418bb06 100755 --- a/tools/code_format/check_format.py +++ b/tools/code_format/check_format.py @@ -692,8 +692,6 @@ def checkSourceLine(line, file_path, reportError): # See: https://github.com/envoyproxy/envoy/issues/12341 if tokenInLine("std::any", line): reportError("Don't use std::any; use absl::any instead") - if tokenInLine("std::get", line): - reportError("Don't use std::get; use absl::get instead") if tokenInLine("std::get_if", line): reportError("Don't use std::get_if; use absl::get_if instead") if tokenInLine("std::holds_alternative", line): diff --git a/tools/code_format/check_format_test_helper.py b/tools/code_format/check_format_test_helper.py index d9c7818d8447..bb08f6518cb7 100755 --- a/tools/code_format/check_format_test_helper.py +++ b/tools/code_format/check_format_test_helper.py @@ -243,7 +243,6 @@ def runChecks(): "std_unordered_set.cc", "Don't use std::unordered_set; use absl::flat_hash_set instead " + "or absl::node_hash_set if pointer stability of keys/values is required") errors += checkUnfixableError("std_any.cc", "Don't use std::any; use absl::any instead") - errors += checkUnfixableError("std_get.cc", "Don't use std::get; use absl::get instead") errors += checkUnfixableError("std_get_if.cc", "Don't use std::get_if; use absl::get_if instead") errors += checkUnfixableError("std_holds_alternative.cc", "Don't use std::holds_alternative; use absl::holds_alternative instead") diff --git a/tools/testdata/.DS_Store b/tools/testdata/.DS_Store new file mode 100644 index 000000000000..f24b79727921 Binary files /dev/null and b/tools/testdata/.DS_Store differ diff --git a/tools/testdata/check_format/std_get.cc b/tools/testdata/check_format/std_get.cc deleted file mode 100644 index ba56dfcdcb7f..000000000000 --- a/tools/testdata/check_format/std_get.cc +++ /dev/null @@ -1,8 +0,0 @@ -#include - -namespace Envoy { - void foo() { - absl::variant x(5); - auto y = std::get(x); - } -} // namespace Envoy