From 65e24b8e34f9d0b05339e3d13fa26a95c35206e0 Mon Sep 17 00:00:00 2001 From: botengyao Date: Fri, 21 Feb 2025 16:33:53 -0500 Subject: [PATCH] secret-provider: update thread_local update method comment (#38459) Signed-off-by: Boteng Yao --- source/common/secret/secret_provider_impl.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source/common/secret/secret_provider_impl.cc b/source/common/secret/secret_provider_impl.cc index 4c83962e1924..53e02be58b74 100644 --- a/source/common/secret/secret_provider_impl.cc +++ b/source/common/secret/secret_provider_impl.cc @@ -65,8 +65,9 @@ ThreadLocalGenericSecretProvider::ThreadLocalGenericSecretProvider( const std::string& ThreadLocalGenericSecretProvider::secret() const { return (*tls_)->value_; } -// This function is executed on the main during xDS update and can throw. +// This function is executed on the main during xDS update. absl::Status ThreadLocalGenericSecretProvider::update() { + ASSERT_IS_MAIN_OR_TEST_THREAD(); std::string value; if (const auto* secret = provider_->secret(); secret != nullptr) { auto value_or_error = Config::DataSource::read(secret->secret(), true, api_);