-
Notifications
You must be signed in to change notification settings - Fork 4.9k
/
Copy pathruntime_impl_test.cc
1300 lines (1090 loc) · 53.1 KB
/
runtime_impl_test.cc
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
#include <memory>
#include <string>
#include "envoy/config/bootstrap/v3/bootstrap.pb.h"
#include "envoy/config/core/v3/config_source.pb.h"
#include "envoy/service/discovery/v3/discovery.pb.h"
#include "envoy/service/runtime/v3/rtds.pb.h"
#include "envoy/type/v3/percent.pb.h"
#include "source/common/config/runtime_utility.h"
#include "source/common/runtime/runtime_features.h"
#include "source/common/runtime/runtime_impl.h"
#include "test/common/stats/stat_test_utility.h"
#include "test/mocks/common.h"
#include "test/mocks/event/mocks.h"
#include "test/mocks/filesystem/mocks.h"
#include "test/mocks/init/mocks.h"
#include "test/mocks/local_info/mocks.h"
#include "test/mocks/protobuf/mocks.h"
#include "test/mocks/runtime/mocks.h"
#include "test/mocks/server/mocks.h"
#include "test/mocks/thread_local/mocks.h"
#include "test/mocks/upstream/cluster_manager.h"
#include "test/test_common/environment.h"
#include "test/test_common/logging.h"
#include "absl/flags/declare.h"
#include "gmock/gmock.h"
#include "gtest/gtest.h"
#ifdef ENVOY_ENABLE_QUIC
#include "quiche/common/platform/api/quiche_flags.h"
#endif
ABSL_DECLARE_FLAG(bool, envoy_reloadable_features_boolean_to_string_fix);
using testing::_;
using testing::Invoke;
using testing::InvokeWithoutArgs;
using testing::MockFunction;
using testing::NiceMock;
using testing::Return;
namespace Envoy {
namespace Runtime {
namespace {
class LoaderImplTest : public testing::Test {
protected:
LoaderImplTest() : api_(Api::createApiForTest(store_)) { local_info_.node_.set_cluster(""); }
virtual void setup() {
EXPECT_CALL(dispatcher_, createFilesystemWatcher_()).WillRepeatedly(InvokeWithoutArgs([this] {
Filesystem::MockWatcher* mock_watcher = new NiceMock<Filesystem::MockWatcher>();
EXPECT_CALL(*mock_watcher, addWatch(_, Filesystem::Watcher::Events::MovedTo, _))
.WillRepeatedly(
Invoke([this](absl::string_view path, uint32_t, Filesystem::Watcher::OnChangedCb cb) {
EXPECT_EQ(path, expected_watch_root_);
on_changed_cbs_.emplace_back(cb);
return absl::OkStatus();
}));
return mock_watcher;
}));
}
Event::MockDispatcher dispatcher_;
NiceMock<ThreadLocal::MockInstance> tls_;
Stats::TestUtil::TestStore store_;
Random::MockRandomGenerator generator_;
std::unique_ptr<LoaderImpl> loader_;
Api::ApiPtr api_;
Upstream::MockClusterManager cm_;
NiceMock<LocalInfo::MockLocalInfo> local_info_;
std::vector<Filesystem::Watcher::OnChangedCb> on_changed_cbs_;
NiceMock<ProtobufMessage::MockValidationVisitor> validation_visitor_;
std::string expected_watch_root_;
};
class DiskLoaderImplTest : public LoaderImplTest {
public:
void SetUp() override {
TestEnvironment::exec(
{TestEnvironment::runfilesPath("test/common/runtime/filesystem_setup.sh")});
}
void TearDown() override {
TestEnvironment::removePath(TestEnvironment::temporaryPath("test/common/runtime/test_data"));
}
void run(const std::string& primary_dir, const std::string& override_dir) {
envoy::config::bootstrap::v3::Runtime runtime;
runtime.mutable_base()->MergeFrom(base_);
expected_watch_root_ = TestEnvironment::temporaryPath(primary_dir);
runtime.set_symlink_root(expected_watch_root_);
runtime.set_subdirectory("envoy");
runtime.set_override_subdirectory(override_dir);
envoy::config::bootstrap::v3::LayeredRuntime layered_runtime;
Config::translateRuntime(runtime, layered_runtime);
absl::StatusOr<std::unique_ptr<Runtime::LoaderImpl>> loader =
Runtime::LoaderImpl::create(dispatcher_, tls_, layered_runtime, local_info_, store_,
generator_, validation_visitor_, *api_);
THROW_IF_NOT_OK(loader.status());
loader_ = std::move(loader.value());
}
void write(const std::string& path, const std::string& value) {
TestEnvironment::writeStringToFileForTest(path, value);
}
void updateDiskLayer(uint32_t layer) {
ASSERT_LT(layer, on_changed_cbs_.size());
EXPECT_TRUE(on_changed_cbs_[layer](Filesystem::Watcher::Events::MovedTo).ok());
}
ProtobufWkt::Struct base_;
};
TEST_F(DiskLoaderImplTest, EmptyKeyTest) {
setup();
run("test/common/runtime/test_data/current", "envoy_override");
EXPECT_FALSE(loader_->snapshot().get("").has_value());
EXPECT_EQ(11, loader_->snapshot().getInteger("", 11));
EXPECT_EQ(1.1, loader_->snapshot().getDouble("", 1.1));
EXPECT_EQ(false, loader_->snapshot().featureEnabled("", 0));
EXPECT_EQ(true, loader_->snapshot().featureEnabled("", 100));
EXPECT_EQ(true, loader_->snapshot().getBoolean("", true));
EXPECT_EQ(false, loader_->snapshot().getBoolean("", false));
}
TEST_F(DiskLoaderImplTest, DoubleUintInteraction) {
setup();
run("test/common/runtime/test_data/current", "envoy_override");
EXPECT_EQ(2UL, loader_->snapshot().getInteger("file3", 1));
EXPECT_EQ(2.0, loader_->snapshot().getDouble("file3", 1.1));
}
TEST_F(DiskLoaderImplTest, DoubleUintInteractionNegatives) {
setup();
run("test/common/runtime/test_data/current", "envoy_override");
EXPECT_EQ(1, loader_->snapshot().getInteger("file_with_negative_double", 1));
EXPECT_EQ(-4.2, loader_->snapshot().getDouble("file_with_negative_double", 1.1));
}
TEST_F(DiskLoaderImplTest, All) {
setup();
run("test/common/runtime/test_data/current", "envoy_override");
// Basic string getting.
EXPECT_EQ("world", loader_->snapshot().get("file2").value().get());
EXPECT_EQ("hello", loader_->snapshot().get("subdir.file").value().get());
EXPECT_EQ("hello\nworld", loader_->snapshot().get("file_lf").value().get());
EXPECT_EQ("hello\r\nworld", loader_->snapshot().get("file_crlf").value().get());
EXPECT_FALSE(loader_->snapshot().get("invalid").has_value());
// Existence checking.
EXPECT_EQ(true, loader_->snapshot().get("file2").has_value());
EXPECT_EQ(true, loader_->snapshot().get("subdir.file").has_value());
EXPECT_EQ(false, loader_->snapshot().get("invalid").has_value());
// Integer getting.
EXPECT_EQ(1UL, loader_->snapshot().getInteger("file1", 1));
EXPECT_EQ(2UL, loader_->snapshot().getInteger("file3", 1));
EXPECT_EQ(123UL, loader_->snapshot().getInteger("file4", 1));
// Double getting.
// Bogus string, expect default.
EXPECT_EQ(42.1, loader_->snapshot().getDouble("file_with_words", 42.1));
// Valid float string.
EXPECT_EQ(23.2, loader_->snapshot().getDouble("file_with_double", 1.1));
// Valid float string followed by newlines.
EXPECT_EQ(3.141, loader_->snapshot().getDouble("file_with_double_newlines", 1.1));
const auto snapshot = reinterpret_cast<const SnapshotImpl*>(&loader_->snapshot());
// Validate that the layer name is set properly for static layers.
EXPECT_EQ("base", snapshot->getLayers()[0]->name());
EXPECT_EQ("root", snapshot->getLayers()[1]->name());
EXPECT_EQ("override", snapshot->getLayers()[2]->name());
EXPECT_EQ("admin", snapshot->getLayers()[3]->name());
// Boolean getting.
// Lower-case boolean specification.
EXPECT_EQ(true, snapshot->getBoolean("file11", false));
EXPECT_EQ(true, snapshot->getBoolean("file11", true));
// Lower-case boolean specification with leading whitespace.
EXPECT_EQ(true, snapshot->getBoolean("file13", true));
EXPECT_EQ(true, snapshot->getBoolean("file13", false));
// File1 is not a boolean. Should take default.
EXPECT_EQ(true, snapshot->getBoolean("file1", true));
EXPECT_EQ(false, snapshot->getBoolean("file1", false));
// Feature defaults.
// test_feature_true is explicitly set true in runtime_features.cc
EXPECT_EQ(true, snapshot->runtimeFeatureEnabled("envoy.reloadable_features.test_feature_true"));
// test_feature_false is not in runtime_features.cc and so is false by default.
EXPECT_EQ(false, snapshot->runtimeFeatureEnabled("envoy.reloadable_features.test_feature_false"));
// Deprecation
EXPECT_EQ(false, snapshot->deprecatedFeatureEnabled(
"envoy.deprecated_features.deprecated.proto:is_deprecated_fatal", false));
// Feature defaults via helper function.
EXPECT_EQ(false, runtimeFeatureEnabled("envoy.reloadable_features.test_feature_false"));
EXPECT_EQ(true, runtimeFeatureEnabled("envoy.reloadable_features.test_feature_true"));
// Files with comments.
EXPECT_EQ(123UL, loader_->snapshot().getInteger("file5", 1));
EXPECT_EQ(2.718, loader_->snapshot().getDouble("file_with_double_comment", 1.1));
EXPECT_EQ("/home#about-us", loader_->snapshot().get("file6").value().get());
EXPECT_EQ("", loader_->snapshot().get("file7").value().get());
// Feature enablement.
EXPECT_CALL(generator_, random()).WillOnce(Return(1));
EXPECT_TRUE(loader_->snapshot().featureEnabled("file3", 1));
EXPECT_CALL(generator_, random()).WillOnce(Return(2));
EXPECT_FALSE(loader_->snapshot().featureEnabled("file3", 1));
// Fractional percent feature enablement
envoy::type::v3::FractionalPercent fractional_percent;
fractional_percent.set_numerator(5);
fractional_percent.set_denominator(envoy::type::v3::FractionalPercent::TEN_THOUSAND);
EXPECT_CALL(generator_, random()).WillOnce(Return(50));
EXPECT_TRUE(loader_->snapshot().featureEnabled("file8", fractional_percent)); // valid data
EXPECT_CALL(generator_, random()).WillOnce(Return(60));
EXPECT_FALSE(loader_->snapshot().featureEnabled("file8", fractional_percent)); // valid data
// We currently expect that runtime values represented as fractional percents that are provided as
// integers are parsed simply as percents (denominator of 100).
EXPECT_CALL(generator_, random()).WillOnce(Return(53));
EXPECT_FALSE(loader_->snapshot().featureEnabled("file10", fractional_percent)); // valid int data
EXPECT_CALL(generator_, random()).WillOnce(Return(51));
EXPECT_TRUE(loader_->snapshot().featureEnabled("file10", fractional_percent)); // valid int data
EXPECT_CALL(generator_, random()).WillOnce(Return(4));
EXPECT_TRUE(
loader_->snapshot().featureEnabled("file9", fractional_percent)); // invalid proto data
EXPECT_CALL(generator_, random()).WillOnce(Return(6));
EXPECT_FALSE(
loader_->snapshot().featureEnabled("file9", fractional_percent)); // invalid proto data
EXPECT_CALL(generator_, random()).WillOnce(Return(4));
EXPECT_TRUE(loader_->snapshot().featureEnabled("file1", fractional_percent)); // invalid data
EXPECT_CALL(generator_, random()).WillOnce(Return(6));
EXPECT_FALSE(loader_->snapshot().featureEnabled("file1", fractional_percent)); // invalid data
// Check stable value
EXPECT_TRUE(loader_->snapshot().featureEnabled("file3", 1, 1));
EXPECT_FALSE(loader_->snapshot().featureEnabled("file3", 1, 3));
// Check stable value and num buckets.
EXPECT_FALSE(loader_->snapshot().featureEnabled("file4", 1, 200, 300));
EXPECT_TRUE(loader_->snapshot().featureEnabled("file4", 1, 122, 300));
// Overrides from override dir
EXPECT_EQ("hello override", loader_->snapshot().get("file1").value().get());
EXPECT_EQ(0, store_.counter("runtime.load_error").value());
EXPECT_EQ(1, store_.counter("runtime.load_success").value());
EXPECT_EQ(24, store_.gauge("runtime.num_keys", Stats::Gauge::ImportMode::NeverImport).value());
EXPECT_EQ(4, store_.gauge("runtime.num_layers", Stats::Gauge::ImportMode::NeverImport).value());
}
TEST_F(DiskLoaderImplTest, UintLargeIntegerConversion) {
setup();
run("test/common/runtime/test_data/current", "envoy_override");
EXPECT_EQ(1, loader_->snapshot().getInteger("file_with_large_integer", 1));
}
TEST_F(DiskLoaderImplTest, GetLayers) {
base_ = TestUtility::parseYaml<ProtobufWkt::Struct>(R"EOF(
foo: whatevs
)EOF");
setup();
run("test/common/runtime/test_data/current", "envoy_override");
const auto& layers = loader_->snapshot().getLayers();
EXPECT_EQ(1, store_.counter("runtime.load_success").value());
EXPECT_EQ(4, layers.size());
EXPECT_EQ(4, store_.gauge("runtime.num_layers", Stats::Gauge::ImportMode::NeverImport).value());
EXPECT_EQ("whatevs", layers[0]->values().find("foo")->second.raw_string_value_);
EXPECT_EQ("hello", layers[1]->values().find("file1")->second.raw_string_value_);
EXPECT_EQ("hello override", layers[2]->values().find("file1")->second.raw_string_value_);
// Admin should be last
EXPECT_NE(nullptr, dynamic_cast<const AdminLayer*>(layers.back().get()));
EXPECT_TRUE(layers[3]->values().empty());
ASSERT_TRUE(loader_->mergeValues({{"foo", "bar"}}).ok());
// The old snapshot and its layers should have been invalidated. Refetch.
const auto& new_layers = loader_->snapshot().getLayers();
EXPECT_EQ("bar", new_layers[3]->values().find("foo")->second.raw_string_value_);
EXPECT_EQ(2, store_.counter("runtime.load_success").value());
}
TEST_F(DiskLoaderImplTest, BadDirectory) {
setup();
run("/baddir", "/baddir");
EXPECT_EQ(0, store_.counter("runtime.load_error").value());
EXPECT_EQ(1, store_.counter("runtime.load_success").value());
EXPECT_EQ(2, store_.gauge("runtime.num_layers", Stats::Gauge::ImportMode::NeverImport).value());
EXPECT_EQ(0, store_.counter("runtime.override_dir_exists").value());
EXPECT_EQ(1, store_.counter("runtime.override_dir_not_exists").value());
}
// Validate that an error in a layer will results in appropriate stats tracking.
TEST_F(DiskLoaderImplTest, DiskLayerFailure) {
setup();
// Symlink loopy configuration will result in an error.
run("test/common/runtime/test_data", "loop");
EXPECT_EQ(1, store_.counter("runtime.load_error").value());
EXPECT_EQ(0, store_.counter("runtime.load_success").value());
EXPECT_EQ(2, store_.gauge("runtime.num_layers", Stats::Gauge::ImportMode::NeverImport).value());
EXPECT_EQ(0, store_.counter("runtime.override_dir_exists").value());
EXPECT_EQ(1, store_.counter("runtime.override_dir_not_exists").value());
}
TEST_F(DiskLoaderImplTest, OverrideFolderDoesNotExist) {
setup();
run("test/common/runtime/test_data/current", "envoy_override_does_not_exist");
EXPECT_EQ("hello", loader_->snapshot().get("file1").value().get());
EXPECT_EQ(0, store_.counter("runtime.load_error").value());
EXPECT_EQ(1, store_.counter("runtime.load_success").value());
EXPECT_EQ(3, store_.gauge("runtime.num_layers", Stats::Gauge::ImportMode::NeverImport).value());
EXPECT_EQ(0, store_.counter("runtime.override_dir_exists").value());
EXPECT_EQ(1, store_.counter("runtime.override_dir_not_exists").value());
}
TEST_F(DiskLoaderImplTest, FileDoesNotExist) {
EXPECT_CALL(dispatcher_, createFilesystemWatcher_()).WillRepeatedly(InvokeWithoutArgs([] {
Filesystem::MockWatcher* mock_watcher = new NiceMock<Filesystem::MockWatcher>();
EXPECT_CALL(*mock_watcher, addWatch(_, Filesystem::Watcher::Events::MovedTo, _))
.WillRepeatedly(Return(absl::InvalidArgumentError("file does not exist")));
return mock_watcher;
}));
EXPECT_THROW_WITH_MESSAGE(
run("test/common/runtime/test_data/current", "envoy_override_does_not_exist"), EnvoyException,
"file does not exist");
}
TEST_F(DiskLoaderImplTest, PercentHandling) {
setup();
run("test/common/runtime/test_data/current", "envoy_override");
envoy::type::v3::FractionalPercent default_value;
// Smoke test integer value of 0, should be interpreted as 0%
{
ASSERT_TRUE(loader_->mergeValues({{"foo", "0"}}).ok());
EXPECT_FALSE(loader_->snapshot().featureEnabled("foo", default_value, 0));
EXPECT_FALSE(loader_->snapshot().featureEnabled("foo", default_value, 5));
}
// Smoke test integer value of 5, should be interpreted as 5%
{
ASSERT_TRUE(loader_->mergeValues({{"foo", "5"}}).ok());
EXPECT_TRUE(loader_->snapshot().featureEnabled("foo", default_value, 0));
EXPECT_TRUE(loader_->snapshot().featureEnabled("foo", default_value, 4));
EXPECT_FALSE(loader_->snapshot().featureEnabled("foo", default_value, 5));
EXPECT_TRUE(loader_->snapshot().featureEnabled("foo", default_value, 100));
}
// Verify uint64 -> uint32 conversion by using a runtime value with all 0s in
// the bottom 32 bits. If it were to be naively treated as a uint32_t then it
// would appear as 0%, but it should be 100% because we assume the
// denominator is 100
{
// NOTE: high_value has to have the property that the lowest 32 bits % 100
// is less than 100. If it's greater than 100 the test will pass whether or
// not the uint32 conversion is handled properly.
uint64_t high_value = 1ULL << 60;
std::string high_value_str = std::to_string(high_value);
ASSERT_TRUE(loader_->mergeValues({{"foo", high_value_str}}).ok());
EXPECT_TRUE(loader_->snapshot().featureEnabled("foo", default_value, 0));
EXPECT_TRUE(loader_->snapshot().featureEnabled("foo", default_value, 50));
EXPECT_TRUE(loader_->snapshot().featureEnabled("foo", default_value, 100));
EXPECT_TRUE(loader_->snapshot().featureEnabled("foo", default_value, 12389));
EXPECT_TRUE(loader_->snapshot().featureEnabled("foo", default_value, 23859235));
}
}
void testNewOverrides(Loader& loader, Stats::TestUtil::TestStore& store) {
Stats::Gauge& admin_overrides_active =
store.gauge("runtime.admin_overrides_active", Stats::Gauge::ImportMode::NeverImport);
// New string.
ASSERT_TRUE(loader.mergeValues({{"foo", "bar"}}).ok());
EXPECT_EQ("bar", loader.snapshot().get("foo").value().get());
EXPECT_EQ(1, admin_overrides_active.value());
// Remove new string.
ASSERT_TRUE(loader.mergeValues({{"foo", ""}}).ok());
EXPECT_FALSE(loader.snapshot().get("foo").has_value());
EXPECT_EQ(0, admin_overrides_active.value());
// New integer.
ASSERT_TRUE(loader.mergeValues({{"baz", "42"}}).ok());
EXPECT_EQ(42, loader.snapshot().getInteger("baz", 0));
EXPECT_EQ(1, admin_overrides_active.value());
// Remove new integer.
ASSERT_TRUE(loader.mergeValues({{"baz", ""}}).ok());
EXPECT_EQ(0, loader.snapshot().getInteger("baz", 0));
EXPECT_EQ(0, admin_overrides_active.value());
// New double.
ASSERT_TRUE(loader.mergeValues({{"beep", "42.1"}}).ok());
EXPECT_EQ(42.1, loader.snapshot().getDouble("beep", 1.2));
EXPECT_EQ(1, admin_overrides_active.value());
// Remove new double.
ASSERT_TRUE(loader.mergeValues({{"beep", ""}}).ok());
EXPECT_EQ(1.2, loader.snapshot().getDouble("beep", 1.2));
EXPECT_EQ(0, admin_overrides_active.value());
}
TEST_F(DiskLoaderImplTest, MergeValues) {
setup();
run("test/common/runtime/test_data/current", "envoy_override");
testNewOverrides(*loader_, store_);
Stats::Gauge& admin_overrides_active =
store_.gauge("runtime.admin_overrides_active", Stats::Gauge::ImportMode::NeverImport);
// Override string
ASSERT_TRUE(loader_->mergeValues({{"file2", "new world"}}).ok());
EXPECT_EQ("new world", loader_->snapshot().get("file2").value().get());
EXPECT_EQ(1, admin_overrides_active.value());
// Remove overridden string
ASSERT_TRUE(loader_->mergeValues({{"file2", ""}}).ok());
EXPECT_EQ("world", loader_->snapshot().get("file2").value().get());
EXPECT_EQ(0, admin_overrides_active.value());
// Override integer
ASSERT_TRUE(loader_->mergeValues({{"file3", "42"}}).ok());
EXPECT_EQ(42, loader_->snapshot().getInteger("file3", 1));
EXPECT_EQ(1, admin_overrides_active.value());
// Remove overridden integer
ASSERT_TRUE(loader_->mergeValues({{"file3", ""}}).ok());
EXPECT_EQ(2, loader_->snapshot().getInteger("file3", 1));
EXPECT_EQ(0, admin_overrides_active.value());
// Override double
ASSERT_TRUE(loader_->mergeValues({{"file_with_double", "42.1"}}).ok());
EXPECT_EQ(42.1, loader_->snapshot().getDouble("file_with_double", 1.1));
EXPECT_EQ(1, admin_overrides_active.value());
// Remove overridden double
ASSERT_TRUE(loader_->mergeValues({{"file_with_double", ""}}).ok());
EXPECT_EQ(23.2, loader_->snapshot().getDouble("file_with_double", 1.1));
EXPECT_EQ(0, admin_overrides_active.value());
// Override override string
ASSERT_TRUE(loader_->mergeValues({{"file1", "hello overridden override"}}).ok());
EXPECT_EQ("hello overridden override", loader_->snapshot().get("file1").value().get());
EXPECT_EQ(1, admin_overrides_active.value());
// Remove overridden override string
ASSERT_TRUE(loader_->mergeValues({{"file1", ""}}).ok());
EXPECT_EQ("hello override", loader_->snapshot().get("file1").value().get());
EXPECT_EQ(0, admin_overrides_active.value());
EXPECT_EQ(0, store_.gauge("runtime.admin_overrides_active", Stats::Gauge::ImportMode::NeverImport)
.value());
EXPECT_EQ(15, store_.counter("runtime.load_success").value());
EXPECT_EQ(4, store_.gauge("runtime.num_layers", Stats::Gauge::ImportMode::NeverImport).value());
}
// Validate that admin overrides disk, disk overrides bootstrap.
TEST_F(DiskLoaderImplTest, LayersOverride) {
base_ = TestUtility::parseYaml<ProtobufWkt::Struct>(R"EOF(
some: thing
other: thang
file2: whatevs
)EOF");
setup();
run("test/common/runtime/test_data/current", "envoy_override");
// Disk overrides bootstrap.
EXPECT_EQ("world", loader_->snapshot().get("file2").value().get());
EXPECT_EQ("thing", loader_->snapshot().get("some").value().get());
EXPECT_EQ("thang", loader_->snapshot().get("other").value().get());
// Admin overrides disk and bootstrap.
ASSERT_TRUE(loader_->mergeValues({{"file2", "pluto"}, {"some", "day soon"}}).ok());
EXPECT_EQ("pluto", loader_->snapshot().get("file2").value().get());
EXPECT_EQ("day soon", loader_->snapshot().get("some").value().get());
EXPECT_EQ("thang", loader_->snapshot().get("other").value().get());
// Admin overrides stick over filesystem updates.
EXPECT_EQ("Layer cake", loader_->snapshot().get("file14").value().get());
EXPECT_EQ("Cheese cake", loader_->snapshot().get("file15").value().get());
ASSERT_TRUE(loader_->mergeValues({{"file14", "Mega layer cake"}}).ok());
EXPECT_EQ("Mega layer cake", loader_->snapshot().get("file14").value().get());
EXPECT_EQ("Cheese cake", loader_->snapshot().get("file15").value().get());
write("test/common/runtime/test_data/current/envoy/file14", "Sad cake");
write("test/common/runtime/test_data/current/envoy/file15", "Happy cake");
updateDiskLayer(0);
EXPECT_EQ("Mega layer cake", loader_->snapshot().get("file14").value().get());
EXPECT_EQ("Happy cake", loader_->snapshot().get("file15").value().get());
}
// Validate that multiple admin layers leads to a configuration load failure.
TEST_F(DiskLoaderImplTest, MultipleAdminLayersFail) {
setup();
envoy::config::bootstrap::v3::LayeredRuntime layered_runtime;
{
auto* layer = layered_runtime.add_layers();
layer->set_name("admin_0");
layer->mutable_admin_layer();
}
{
auto* layer = layered_runtime.add_layers();
layer->set_name("admin_1");
layer->mutable_admin_layer();
}
absl::StatusOr<std::unique_ptr<Runtime::LoaderImpl>> loader =
Runtime::LoaderImpl::create(dispatcher_, tls_, layered_runtime, local_info_, store_,
generator_, validation_visitor_, *api_);
EXPECT_EQ(loader.status().message(),
"Too many admin layers specified in LayeredRuntime, at most one may be specified");
}
class StaticLoaderImplTest : public LoaderImplTest {
protected:
void setup() override {
LoaderImplTest::setup();
envoy::config::bootstrap::v3::LayeredRuntime layered_runtime;
{
auto* layer = layered_runtime.add_layers();
layer->set_name("base");
layer->mutable_static_layer()->MergeFrom(base_);
}
{
auto* layer = layered_runtime.add_layers();
layer->set_name("admin");
layer->mutable_admin_layer();
}
absl::StatusOr<std::unique_ptr<Runtime::LoaderImpl>> loader =
Runtime::LoaderImpl::create(dispatcher_, tls_, layered_runtime, local_info_, store_,
generator_, validation_visitor_, *api_);
THROW_IF_NOT_OK(loader.status());
loader_ = std::move(loader.value());
}
ProtobufWkt::Struct base_;
};
TEST_F(StaticLoaderImplTest, All) {
setup();
EXPECT_FALSE(loader_->snapshot().get("foo").has_value());
EXPECT_EQ(1UL, loader_->snapshot().getInteger("foo", 1));
EXPECT_EQ(1.1, loader_->snapshot().getDouble("foo", 1.1));
EXPECT_CALL(generator_, random()).WillOnce(Return(49));
EXPECT_TRUE(loader_->snapshot().featureEnabled("foo", 50));
testNewOverrides(*loader_, store_);
}
#ifdef ENVOY_ENABLE_QUIC
TEST_F(StaticLoaderImplTest, QuicheReloadableFlags) {
EXPECT_TRUE(GetQuicheReloadableFlag(quic_testonly_default_true));
EXPECT_FALSE(GetQuicheReloadableFlag(quic_testonly_default_false));
SetQuicheReloadableFlag(quic_testonly_default_true, false);
EXPECT_FALSE(GetQuicheReloadableFlag(quic_testonly_default_true));
EXPECT_FALSE(GetQuicheReloadableFlag(quic_testonly_default_false));
// Test that Quiche flags can be overwritten via Envoy runtime config.
base_ = TestUtility::parseYaml<ProtobufWkt::Struct>(
"envoy.reloadable_features.FLAGS_envoy_quiche_reloadable_flag_quic_testonly_default_true: "
"true");
setup();
EXPECT_TRUE(GetQuicheReloadableFlag(quic_testonly_default_true));
EXPECT_FALSE(GetQuicheReloadableFlag(quic_testonly_default_false));
// Test that Quiche flags can be overwritten again.
base_ = TestUtility::parseYaml<ProtobufWkt::Struct>(
"envoy.reloadable_features.FLAGS_envoy_quiche_reloadable_flag_quic_testonly_default_true: "
"false");
setup();
EXPECT_FALSE(GetQuicheReloadableFlag(quic_testonly_default_true));
EXPECT_FALSE(GetQuicheReloadableFlag(quic_testonly_default_false));
}
#endif
TEST_F(StaticLoaderImplTest, RemovedFlags) {
base_ = TestUtility::parseYaml<ProtobufWkt::Struct>(R"EOF(
envoy.reloadable_features.removed_foo: true
)EOF");
EXPECT_ENVOY_BUG(setup(), "envoy.reloadable_features.removed_foo");
}
TEST_F(StaticLoaderImplTest, ProtoParsingInvalidField) {
base_ = TestUtility::parseYaml<ProtobufWkt::Struct>("file0:");
EXPECT_THROW_WITH_MESSAGE(setup(), EnvoyException, "Invalid runtime entry value for file0");
}
TEST_F(StaticLoaderImplTest, ProtoParsing) {
// Validate proto parsing sanity.
base_ = TestUtility::parseYaml<ProtobufWkt::Struct>(R"EOF(
file1: hello override
file2: world
file3: 2
file4: 123
file8:
numerator: 52
denominator: HUNDRED
file80:
numerator: 52
denominator: TEN_THOUSAND
file800:
numerator: 52
denominator: MILLION
file9:
numerator: 100
denominator: NONSENSE
file10: 52
file11: true
file13: false
subdir:
file: "hello"
numerator_only:
numerator: 52
denominator_only:
denominator: HUNDRED
false_friend:
numerator: 100
foo: bar
empty: {}
file_with_words: "some words"
file_with_double: 23.2
file_lf: "hello\nworld"
file_crlf: "hello\r\nworld"
bool_as_int0: 0
bool_as_int1: 1
)EOF");
setup();
// Basic string getting.
EXPECT_EQ("world", loader_->snapshot().get("file2").value().get());
EXPECT_EQ("hello", loader_->snapshot().get("subdir.file").value().get());
EXPECT_EQ("hello\nworld", loader_->snapshot().get("file_lf").value().get());
EXPECT_EQ("hello\r\nworld", loader_->snapshot().get("file_crlf").value().get());
EXPECT_FALSE(loader_->snapshot().get("invalid").has_value());
// Integer getting.
EXPECT_EQ(1UL, loader_->snapshot().getInteger("file1", 1));
EXPECT_EQ(2UL, loader_->snapshot().getInteger("file3", 1));
EXPECT_EQ(123UL, loader_->snapshot().getInteger("file4", 1));
// Double getting.
EXPECT_EQ(1.1, loader_->snapshot().getDouble("file_with_words", 1.1));
EXPECT_EQ(23.2, loader_->snapshot().getDouble("file_with_double", 1.1));
EXPECT_EQ(2.0, loader_->snapshot().getDouble("file3", 3.3));
// Boolean getting.
const auto snapshot = reinterpret_cast<const SnapshotImpl*>(&loader_->snapshot());
EXPECT_EQ(true, snapshot->getBoolean("file11", true));
EXPECT_EQ(true, snapshot->getBoolean("file11", false));
EXPECT_EQ(false, snapshot->getBoolean("file13", true));
EXPECT_EQ(false, snapshot->getBoolean("file13", false));
EXPECT_EQ(0, snapshot->getInteger("bool_as_int0", 333));
EXPECT_EQ(1, snapshot->getInteger("bool_as_int1", 333));
EXPECT_EQ(false, snapshot->getBoolean("bool_as_int0", true));
EXPECT_EQ(false, snapshot->getBoolean("bool_as_int0", false));
EXPECT_EQ(true, snapshot->getBoolean("bool_as_int1", false));
EXPECT_EQ(true, snapshot->getBoolean("bool_as_int1", true));
EXPECT_EQ(true, snapshot->getBoolean("file11", false));
EXPECT_EQ(true, snapshot->getBoolean("file11", true));
// Test that a double value is not parsed as a boolean even though integers are fine.
EXPECT_EQ(true, snapshot->getBoolean("file_with_double", true));
EXPECT_EQ(false, snapshot->getBoolean("file_with_double", false));
// Not a boolean. Expect the default.
EXPECT_EQ(true, snapshot->getBoolean("file1", true));
EXPECT_EQ(false, snapshot->getBoolean("file1", false));
EXPECT_EQ(true, snapshot->getBoolean("blah.blah", true));
EXPECT_EQ(false, snapshot->getBoolean("blah.blah", false));
// Fractional percent feature enablement
envoy::type::v3::FractionalPercent fractional_percent;
fractional_percent.set_numerator(5);
fractional_percent.set_denominator(envoy::type::v3::FractionalPercent::MILLION);
EXPECT_CALL(generator_, random()).WillOnce(Return(50));
EXPECT_TRUE(loader_->snapshot().featureEnabled("file8", fractional_percent)); // valid data
EXPECT_CALL(generator_, random()).WillOnce(Return(50));
EXPECT_TRUE(loader_->snapshot().featureEnabled("file80", fractional_percent)); // valid data
EXPECT_CALL(generator_, random()).WillOnce(Return(50));
EXPECT_TRUE(loader_->snapshot().featureEnabled("file800", fractional_percent)); // valid data
EXPECT_CALL(generator_, random()).WillOnce(Return(60));
EXPECT_FALSE(loader_->snapshot().featureEnabled("file8", fractional_percent)); // valid data
// We currently expect that runtime values represented as fractional percents that are provided as
// integers are parsed simply as percents (denominator of 100).
EXPECT_CALL(generator_, random()).WillOnce(Return(53));
EXPECT_FALSE(loader_->snapshot().featureEnabled("file10", fractional_percent)); // valid int data
EXPECT_CALL(generator_, random()).WillOnce(Return(51));
EXPECT_TRUE(loader_->snapshot().featureEnabled("file10", fractional_percent)); // valid int data
// Invalid fractional percent is ignored.
EXPECT_CALL(generator_, random()).WillOnce(Return(4));
EXPECT_TRUE(
loader_->snapshot().featureEnabled("file9", fractional_percent)); // invalid proto data
EXPECT_CALL(generator_, random()).WillOnce(Return(6));
EXPECT_FALSE(
loader_->snapshot().featureEnabled("file9", fractional_percent)); // invalid proto data
EXPECT_CALL(generator_, random()).WillOnce(Return(4));
EXPECT_TRUE(
loader_->snapshot().featureEnabled("false_friend", fractional_percent)); // invalid proto data
EXPECT_CALL(generator_, random()).WillOnce(Return(6));
EXPECT_FALSE(
loader_->snapshot().featureEnabled("false_friend", fractional_percent)); // invalid proto data
// Numerator only FractionalPercent is handled.
EXPECT_CALL(generator_, random()).WillOnce(Return(50));
EXPECT_TRUE(
loader_->snapshot().featureEnabled("numerator_only", fractional_percent)); // valid data
EXPECT_CALL(generator_, random()).WillOnce(Return(60));
EXPECT_FALSE(
loader_->snapshot().featureEnabled("numerator_only", fractional_percent)); // valid data
// Denominator only FractionalPercent is handled.
EXPECT_CALL(generator_, random()).WillOnce(Return(4));
EXPECT_FALSE(
loader_->snapshot().featureEnabled("denominator_only", fractional_percent)); // valid data
EXPECT_CALL(generator_, random()).WillOnce(Return(6));
EXPECT_FALSE(
loader_->snapshot().featureEnabled("denominator_only", fractional_percent)); // valid data
// Empty message is handled.
EXPECT_CALL(generator_, random()).WillOnce(Return(4));
EXPECT_FALSE(loader_->snapshot().featureEnabled("empty", fractional_percent)); // valid data
EXPECT_CALL(generator_, random()).WillOnce(Return(6));
EXPECT_FALSE(loader_->snapshot().featureEnabled("empty", fractional_percent)); // valid data
EXPECT_EQ(0, store_.counter("runtime.load_error").value());
EXPECT_EQ(1, store_.counter("runtime.load_success").value());
EXPECT_EQ(22, store_.gauge("runtime.num_keys", Stats::Gauge::ImportMode::NeverImport).value());
EXPECT_EQ(2, store_.gauge("runtime.num_layers", Stats::Gauge::ImportMode::NeverImport).value());
// While null values are generally filtered out by walkProtoValue, test manually.
ProtobufWkt::Value empty_value;
const_cast<SnapshotImpl&>(dynamic_cast<const SnapshotImpl&>(loader_->snapshot()))
.createEntry(empty_value, "");
}
TEST_F(StaticLoaderImplTest, InvalidNumerator) {
base_ = TestUtility::parseYaml<ProtobufWkt::Struct>(R"EOF(
invalid_numerator:
numerator: 111
denominator: HUNDRED
)EOF");
setup();
envoy::type::v3::FractionalPercent fractional_percent;
// There is no assertion here - when numerator is invalid
// featureEnabled() will just drop debug log line.
EXPECT_CALL(generator_, random()).WillOnce(Return(500000));
EXPECT_LOG_CONTAINS("debug",
"runtime key 'invalid_numerator': numerator (111) > denominator (100), "
"condition always evaluates to true",
loader_->snapshot().featureEnabled("invalid_numerator", fractional_percent));
}
TEST_F(StaticLoaderImplTest, RuntimeFromNonWorkerThreads) {
// Force the thread to be considered a non-worker thread.
tls_.registered_ = false;
setup();
// Set up foo -> bar
ASSERT_TRUE(loader_->mergeValues({{"foo", "bar"}}).ok());
EXPECT_EQ("bar", loader_->threadsafeSnapshot()->get("foo").value().get());
const Snapshot* original_snapshot_pointer = loader_->threadsafeSnapshot().get();
// Now set up a test thread which verifies foo -> bar
//
// Then change foo and make sure the test thread picks up the change.
bool read_bar = false;
bool updated_eep = false;
Thread::MutexBasicLockable mutex;
Thread::CondVar foo_read;
Thread::CondVar foo_changed;
const Snapshot* original_thread_snapshot_pointer = nullptr;
auto thread = Thread::threadFactoryForTest().createThread([&]() {
{
Thread::LockGuard lock(mutex);
EXPECT_EQ("bar", loader_->threadsafeSnapshot()->get("foo").value().get());
read_bar = true;
original_thread_snapshot_pointer = loader_->threadsafeSnapshot().get();
EXPECT_EQ(original_thread_snapshot_pointer, loader_->threadsafeSnapshot().get());
foo_read.notifyOne();
}
{
Thread::LockGuard lock(mutex);
if (!updated_eep) {
foo_changed.wait(mutex);
}
EXPECT_EQ("eep", loader_->threadsafeSnapshot()->get("foo").value().get());
}
});
{
Thread::LockGuard lock(mutex);
if (!read_bar) {
foo_read.wait(mutex);
}
ASSERT_TRUE(loader_->mergeValues({{"foo", "eep"}}).ok());
updated_eep = true;
}
{
Thread::LockGuard lock(mutex);
foo_changed.notifyOne();
EXPECT_EQ("eep", loader_->threadsafeSnapshot()->get("foo").value().get());
}
thread->join();
EXPECT_EQ(original_thread_snapshot_pointer, original_snapshot_pointer);
}
class DiskLayerTest : public testing::Test {
protected:
DiskLayerTest() : api_(Api::createApiForTest()) {}
static void SetUpTestSuite() { // NOLINT(readability-identifier-naming)
TestEnvironment::exec(
{TestEnvironment::runfilesPath("test/common/runtime/filesystem_setup.sh")});
}
static void TearDownTestSuite() {
TestEnvironment::removePath(TestEnvironment::temporaryPath("test/common/runtime/test_data"));
}
Api::ApiPtr api_;
};
TEST_F(DiskLayerTest, IllegalPath) {
absl::Status creation_status;
#ifdef WIN32
DiskLayer layer("test", R"EOF(\\.\)EOF", *api_, creation_status);
EXPECT_EQ(creation_status.message(), R"EOF(Invalid path: \\.\)EOF");
#else
DiskLayer layer("test", "/dev", *api_, creation_status);
EXPECT_EQ(creation_status.message(), "Invalid path: /dev");
#endif
}
// Validate that we catch recursion that goes too deep in the runtime filesystem
// walk.
TEST_F(DiskLayerTest, Loop) {
absl::Status creation_status;
DiskLayer layer("test", TestEnvironment::temporaryPath("test/common/runtime/test_data/loop"),
*api_, creation_status);
EXPECT_EQ(creation_status.message(), "Walk recursion depth exceeded 16");
}
TEST(NoRuntime, FeatureEnabled) {
// Feature defaults work with no runtime setup.
EXPECT_EQ(false, runtimeFeatureEnabled("envoy.reloadable_features.test_feature_false"));
EXPECT_EQ(true, runtimeFeatureEnabled("envoy.reloadable_features.test_feature_true"));
}
TEST(NoRuntime, DefaultIntValues) {
// Feature defaults work with no runtime setup.
EXPECT_ENVOY_BUG(
EXPECT_EQ(0x1230000ABCDULL,
getInteger("envoy.reloadable_features.test_int_feature_default", 0x1230000ABCDULL)),
"requested an unsupported integer");
}
// Test RTDS layer(s).
class RtdsLoaderImplTest : public LoaderImplTest {
public:
void setup() override {
LoaderImplTest::setup();
envoy::config::bootstrap::v3::LayeredRuntime config;
*config.add_layers()->mutable_static_layer() =
TestUtility::parseYaml<ProtobufWkt::Struct>(R"EOF(
foo: whatevs
bar: yar
)EOF");
for (const auto& layer_resource_name : layers_) {
auto* layer = config.add_layers();
layer->set_name(layer_resource_name);
auto* rtds_layer = layer->mutable_rtds_layer();
rtds_layer->set_name(layer_resource_name);
rtds_layer->mutable_rtds_config();
}
EXPECT_CALL(cm_, subscriptionFactory()).Times(layers_.size());
ON_CALL(cm_.subscription_factory_, subscriptionFromConfigSource(_, _, _, _, _, _))
.WillByDefault(testing::Invoke(
[this](const envoy::config::core::v3::ConfigSource&, absl::string_view, Stats::Scope&,
Config::SubscriptionCallbacks& callbacks, Config::OpaqueResourceDecoderSharedPtr,
const Config::SubscriptionOptions&) -> Config::SubscriptionPtr {
auto ret = std::make_unique<testing::NiceMock<Config::MockSubscription>>();
rtds_subscriptions_.push_back(ret.get());
rtds_callbacks_.push_back(&callbacks);
return ret;
}));
absl::StatusOr<std::unique_ptr<Runtime::LoaderImpl>> loader = Runtime::LoaderImpl::create(
dispatcher_, tls_, config, local_info_, store_, generator_, validation_visitor_, *api_);
THROW_IF_NOT_OK(loader.status());
loader_ = std::move(loader.value());
THROW_IF_NOT_OK(loader_->initialize(cm_));
for (auto* sub : rtds_subscriptions_) {
EXPECT_CALL(*sub, start(_));
}
loader_->startRtdsSubscriptions(rtds_init_callback_.AsStdFunction());
// Validate that the layer name is set properly for dynamic layers.
EXPECT_EQ(layers_[0], loader_->snapshot().getLayers()[1]->name());
EXPECT_EQ("whatevs", loader_->snapshot().get("foo").value().get());
EXPECT_EQ("yar", loader_->snapshot().get("bar").value().get());
EXPECT_FALSE(loader_->snapshot().get("baz").has_value());
EXPECT_EQ(0, store_.counter("runtime.load_error").value());
EXPECT_EQ(1, store_.counter("runtime.load_success").value());
EXPECT_EQ(2, store_.gauge("runtime.num_keys", Stats::Gauge::ImportMode::NeverImport).value());
EXPECT_EQ(1 + layers_.size(),
store_.gauge("runtime.num_layers", Stats::Gauge::ImportMode::NeverImport).value());
}
void addLayer(absl::string_view name) { layers_.emplace_back(name); }
void doOnConfigUpdateVerifyNoThrow(const envoy::service::runtime::v3::Runtime& runtime,
uint32_t callback_index = 0) {
const auto decoded_resources = TestUtility::decodeResources({runtime});
EXPECT_TRUE(
rtds_callbacks_[callback_index]->onConfigUpdate(decoded_resources.refvec_, "").ok());
}
void doDeltaOnConfigUpdateVerifyNoThrow(const envoy::service::runtime::v3::Runtime& runtime) {
const auto decoded_resources = TestUtility::decodeResources({runtime});
EXPECT_TRUE(rtds_callbacks_[0]->onConfigUpdate(decoded_resources.refvec_, {}, "").ok());
}
void doDeltaOnConfigRemovalVerifyNoThrow(const std::string& resource_name) {
Protobuf::RepeatedPtrField<std::string> removed_resources;
*removed_resources.Add() = resource_name;
EXPECT_TRUE(rtds_callbacks_[0]->onConfigUpdate({}, removed_resources, "").ok());
}
std::vector<std::string> layers_{"some_resource"};
std::vector<Config::SubscriptionCallbacks*> rtds_callbacks_;
std::vector<Config::MockSubscription*> rtds_subscriptions_;
MockFunction<void()> rtds_init_callback_;
};
// Empty resource lists are rejected.
TEST_F(RtdsLoaderImplTest, UnexpectedSizeEmpty) {
setup();
EXPECT_CALL(rtds_init_callback_, Call());
EXPECT_EQ(rtds_callbacks_[0]->onConfigUpdate({}, "").message(),
"Unexpected RTDS resource length, number of added resources 0, number of removed "
"resources 0");
EXPECT_EQ(0, store_.counter("runtime.load_error").value());
EXPECT_EQ(1, store_.counter("runtime.load_success").value());
EXPECT_EQ(2, store_.gauge("runtime.num_keys", Stats::Gauge::ImportMode::NeverImport).value());
EXPECT_EQ(2, store_.gauge("runtime.num_layers", Stats::Gauge::ImportMode::NeverImport).value());
}
// > 1 length lists are rejected.
TEST_F(RtdsLoaderImplTest, UnexpectedSizeTooMany) {
setup();
const envoy::service::runtime::v3::Runtime runtime;
const auto decoded_resources = TestUtility::decodeResources({runtime, runtime});
EXPECT_CALL(rtds_init_callback_, Call());
EXPECT_EQ(rtds_callbacks_[0]->onConfigUpdate(decoded_resources.refvec_, "").message(),
"Unexpected RTDS resource length, number of added resources 2, number of removed "
"resources 0");
EXPECT_EQ(0, store_.counter("runtime.load_error").value());
EXPECT_EQ(1, store_.counter("runtime.load_success").value());
EXPECT_EQ(2, store_.gauge("runtime.num_keys", Stats::Gauge::ImportMode::NeverImport).value());