Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting initial validators for jumpstart DKG #1052

Closed
ameba23 opened this issue Sep 13, 2024 · 1 comment · Fixed by #1053
Closed

Selecting initial validators for jumpstart DKG #1052

ameba23 opened this issue Sep 13, 2024 · 1 comment · Fixed by #1053
Assignees

Comments

@ameba23
Copy link
Contributor

ameba23 commented Sep 13, 2024

In trying to write an end-to-end test #1010 i found there is an issue with how we select who performs the initial jumpstart DKG.

Currently the entire validator set is selected. Which works great as long as there are n validators. If there are more than n, we need a way to select n to be the initial signer committee.

This issue is currently not picked up by our tests, because the jumpstart test uses the development chainspec, with 3 TSS nodes, and n = 3. If we try to run this test using the integration test chainspec with 4 TSS nodes, the test fails.

In order to do a full test with both a jump start and a reshare, we need 4 TSS nodes.

This means we need a way to select n initial nodes from the validator set. We could do this deterministically using block number. This means that whoever submits the jump start extrinsic can choose who these validators are by waiting until a particular block.

Other options would be:

  • To use the substrate randomness API - but we then need to store the chosen validators so that the TS servers can check it.
  • To automatically begin the jumpstart as soon as the nth validator joins.
@ameba23
Copy link
Contributor Author

ameba23 commented Sep 13, 2024

I made a draft PR where we select validators using block number - im not sure if it is the best solution but it at least serves to demonstrate what i am talking about.

@ameba23 ameba23 self-assigned this Sep 16, 2024
@ameba23 ameba23 moved this from 📋 Backlog to 🏗 In progress in Entropy Core Sep 16, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Entropy Core Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant