Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range validation for ints sets bad c-level validator value #684

Closed
corranwebster opened this issue Dec 24, 2019 · 0 comments · Fixed by #805
Closed

Range validation for ints sets bad c-level validator value #684

corranwebster opened this issue Dec 24, 2019 · 0 comments · Fixed by #805
Assignees
@mdickinson
Labels
type: bug
Milestone
6.0.0 release

Comments

@corranwebster
Copy link
Contributor

The int range c-level validator (validator constant 3) has been removed, but this code:

traits/traits/trait_types.py

Line 1672 in 761d76d

kind = 3
can still set it.

It turns out in this case that the fast validator will never be set, but this is dangerous as future changes may inadvertently change that.

This may be moot with #594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdickinson mdickinson

Labels
type: bug
Projects
None yet
Milestone
6.0.0 release
Development

Successfully merging a pull request may close this issue.

Make it less likely that we use ValidateTrait.int_range accidentally enthought/traits
2 participants
@corranwebster @mdickinson