Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor router implementations to remove duplication #383

Open
Tracked by #375
mdickinson opened this issue Jul 8, 2021 · 2 comments
Open
Tracked by #375

Refactor router implementations to remove duplication #383

mdickinson opened this issue Jul 8, 2021 · 2 comments
Labels
type: refactor Cleanup or refactoring tasks that don't add functionality or fix bugs

Comments

@mdickinson
Copy link
Member

There's a lot of duplication between the MultithreadingRouter and MultiprocessingRouter classes.

That duplication could be factored out into a base class. Another possibility is that the MultiprocessingRouter could own a MultithreadingRouter - the MultiprocessingRouter can be viewed as a combination of a MultithreadingRouter with the extra machinery required to do cross-process communication.
@mdickinson mdickinson added the type: refactor Cleanup or refactoring tasks that don't add functionality or fix bugs label Jul 8, 2021
@mdickinson mdickinson mentioned this issue Jul 8, 2021
Closed
5 tasks
@mdickinson mdickinson added this to the Release 0.3.0 milestone Jul 8, 2021
@mdickinson
Copy link
Member Author

Would be nice to get this into the 0.3.0 release, but may not be feasible.

@mdickinson
Copy link
Member Author

I'm going to push this until after the release.

@mdickinson mdickinson removed this from the Release 0.3.0 milestone Jul 13, 2021
@mdickinson mdickinson mentioned this issue Jul 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: refactor Cleanup or refactoring tasks that don't add functionality or fix bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdickinson