Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elastic-rebuild-all.sh fails silently #1263

Open
jamesmontalvo3 opened this issue Jun 11, 2020 · 0 comments
Open

elastic-rebuild-all.sh fails silently #1263

jamesmontalvo3 opened this issue Jun 11, 2020 · 0 comments

Comments

@jamesmontalvo3
Copy link
Contributor

elastic-rebuild-all.sh has a block like:

	# If the above command had a failing exit code
	if [[ $? -ne 0 ]]; then

		# FIXME #577 #681: add notification/warning system here
		echo "elastic-build-index FAILED for \"$wiki_id\" at $endtimestamp"

	# if the above command had a passing exit code (e.g. zero)
	else
		echo "elastic-build-index completed for \"$wiki_id\" at $endtimestamp"
	fi

In the failing condition, it should either exit 1 immediately or it should sum the number of failing wikis, then exit ${SUM} at the end. This will cause meza deploy ... to die on the failing command. Perhaps we don't actually want it to die, however, and instead it should log the failure and continue. That way we could identify the problem faster. Bonus points for printing good log info on failure.

Additionally, the command preceding the block above (bash "{{ m_deploy }}/elastic-build-index.sh") may also not be exiting with a failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant